third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h - Issue 2350603002: Ignore zero-height fragments during margin collapsing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h

Issue 2350603002: Ignore zero-height fragments during margin collapsing (Closed)

Patch Set: renamed children_fragment -> fragment, added spaces before parentheses Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc » ('j') | third_party/WebKit/Source/core/layout/ng/ng_units.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h

index e4d1d5f1b60c7867fed493f351050988b2368cad..23f50fde71b6fcba8d698c300f144efefd342fe7 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h

+++ b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h

@@ -52,11 +52,11 @@ class CORE_EXPORT NGBlockLayoutAlgorithm : public NGLayoutAlgorithm {

// @param space Constraint space for the block.

// @param child_margins Margins information for the current child.

- // @param children_margin_strut MarginStrut for children of the current child.

+ // @param fragment Current child's fragment.

// @return Margin block start based on collapsed margins result.

LayoutUnit CollapseMargins(const NGConstraintSpace& space,

const NGBoxStrut& child_margins,

- const NGMarginStrut& children_margin_strut);

+ const NGFragment& fragment);

RefPtr<const ComputedStyle> style_;

Member<NGBox> first_child_;