Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h

Issue 2350603002: Ignore zero-height fragments during margin collapsing (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h
index e4d1d5f1b60c7867fed493f351050988b2368cad..a471b5a2fd702b6cf9b4212ab497c1575775ef7b 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h
@@ -52,11 +52,11 @@ class CORE_EXPORT NGBlockLayoutAlgorithm : public NGLayoutAlgorithm {
//
// @param space Constraint space for the block.
// @param child_margins Margins information for the current child.
- // @param children_margin_strut MarginStrut for children of the current child.
+ // @param fragment Children's fragment.
ikilpatrick 2016/09/19 17:04:19 Child fragment or Current child fragment?
Gleb Lanbin 2016/09/19 17:39:52 Done.
// @return Margin block start based on collapsed margins result.
LayoutUnit CollapseMargins(const NGConstraintSpace& space,
const NGBoxStrut& child_margins,
- const NGMarginStrut& children_margin_strut);
+ const NGFragment& fragment);
RefPtr<const ComputedStyle> style_;
Member<NGBox> first_child_;

Powered by Google App Engine
This is Rietveld 408576698