Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h

Issue 2350603002: Ignore zero-height fragments during margin collapsing (Closed)
Patch Set: Set writing mode and fixed size on style_. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h b/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h
index 998a2aa8fe1e10f6d3164c892b70c839608de132..524ac679dc2c58bfc2afd789fd7d5f2499738362 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h
@@ -27,8 +27,6 @@ class CORE_EXPORT NGFragmentBuilder final
NGFragmentBuilder& AddChild(NGFragment*, NGLogicalOffset);
// Sets MarginStrut for the resultant fragment.
- // These 2 methods below should be only called once as we update the
- // fragment's MarginStrut block start/end from first/last children MarginStrut
NGFragmentBuilder& SetMarginStrutBlockStart(const NGMarginStrut& from);
NGFragmentBuilder& SetMarginStrutBlockEnd(const NGMarginStrut& from);
@@ -52,11 +50,6 @@ class CORE_EXPORT NGFragmentBuilder final
HeapVector<Member<NGPhysicalFragmentBase>> children_;
Vector<NGLogicalOffset> offsets_;
-
- // Whether MarginStrut block start/end was updated.
- // It's used for DCHECK safety check.
- bool is_margin_strut_block_start_updated_ : 1;
- bool is_margin_strut_block_end_updated_ : 1;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698