Chromium Code Reviews Chromium Code Reviews
Issue 23506023:
Add div displaying the currently executing test. (Closed)
Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/| Index: tools/testing/dart/browser_controller.dart |
| =================================================================== |
| --- tools/testing/dart/browser_controller.dart (revision 27017) |
| +++ tools/testing/dart/browser_controller.dart (working copy) |
| @@ -48,7 +48,7 @@ |
| Browser(); |
| - factory Browser.byName(String name) { |
| + factory Browser.byName(String name, [String binaryLocation]) { |
|
kustermann
2013/09/03 07:20:24
unused variable!
ricow1
2013/09/03 07:27:23
Not meant for this cl
|
| if (name == 'ff' || name == 'firefox') { |
| return new Firefox(); |
| } else if (name == 'chrome') { |
| @@ -459,7 +459,7 @@ |
| * The binary used to run firefox - changing this can be nececcary for |
| * testing or using non standard firefox installation. |
| */ |
| - static const String binary = "firefox"; |
| + static const String _binary = "firefox"; |
|
kustermann
2013/09/03 07:20:24
This doesn't work. looking at line 484, you still
ricow1
2013/09/03 07:27:23
Sure, again unrelated
|
| static const String enablePopUp = |
| 'user_pref("dom.disable_open_during_load", false);'; |
| @@ -1055,6 +1055,7 @@ |
| function run(url) { |
| number_of_tests++; |
| document.getElementById('number').innerHTML = number_of_tests; |
| + document.getElementById('currently_executing').innerHTML = url; |
|
kustermann
2013/09/03 07:20:24
There's actually no need to query it again and aga
ricow1
2013/09/03 07:27:23
Done.
|
| if (use_iframe) { |
| embedded_iframe.src = url; |
| } else { |
| @@ -1129,7 +1130,8 @@ |
| </script> |
| </head> |
| <body onload="startTesting()"> |
| - Dart test driver, number of tests: <div id="number"></div> |
| + Dart test driver, number of tests: <div id="number"></div><br> |
| + Currently executing: <div id="currently_executing"></div> |
| <iframe id="embedded_iframe"></iframe> |
| </body> |
| </html> |
