Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 23506020: Merged r16358, r16372, r16406, r16431, r16443 into 3.20 branch. (Closed)

Created:
7 years, 3 months ago by Jakob Kummerow
Modified:
7 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Merged r16358, r16372, r16406, r16431, r16443 into 3.20 branch. Fix Cluster Fuzz stack frame corruption bug. MIPS: Fix Cluster Fuzz stack frame corruption bug. Delete HAbnormalExit. It does more harm than good. Always visit branches during HGraph building Make VisitStatements() consistent among all AstVisitor implementations BUG=v8:2843, chromium:280333 R=mstarzinger@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16482

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -88 lines) Patch
M src/arm/code-stubs-arm.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/ast.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/hydrogen.cc View 3 chunks +3 lines, -13 lines 0 comments Download
M src/hydrogen-environment-liveness.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/hydrogen-instructions.h View 2 chunks +0 lines, -11 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
A + test/mjsunit/compiler/type-feedback-after-throw.js View 1 chunk +7 lines, -9 lines 0 comments Download
A + test/mjsunit/regress/regress-2843.js View 1 chunk +12 lines, -11 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-280333.js View 1 chunk +12 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
7 years, 3 months ago (2013-09-02 16:33:48 UTC) #1
Michael Starzinger
LGTM (rubber-stamped).
7 years, 3 months ago (2013-09-02 16:34:42 UTC) #2
Jakob Kummerow
7 years, 3 months ago (2013-09-02 16:36:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16482 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698