Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Unified Diff: Source/web/WebViewImpl.h

Issue 23506013: Make the embedder responsible for creating the WebFrame (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: wordmith a comment Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/WebViewImpl.h
diff --git a/Source/web/WebViewImpl.h b/Source/web/WebViewImpl.h
index 0b49f02aecdad3889e4638a35749739574fe671e..f1fce4c5fe9db734214cc23e2996a1c3b7925732 100644
--- a/Source/web/WebViewImpl.h
+++ b/Source/web/WebViewImpl.h
@@ -128,6 +128,7 @@ class WebViewImpl : public WebView
, public WebCore::PagePopupDriver
, public PageWidgetEventHandler {
public:
+ static WebViewImpl* create(WebViewClient*);
// WebWidget methods:
virtual void close();
@@ -181,8 +182,8 @@ public:
virtual void didExitCompositingMode();
// WebView methods:
+ virtual void setMainFrame(WebFrame*);
virtual void initializeMainFrame(WebFrameClient*);
- virtual void initializeHelperPluginFrame(WebFrameClient*);
virtual void setAutofillClient(WebAutofillClient*);
virtual void setDevToolsAgentClient(WebDevToolsAgentClient*);
virtual void setPermissionClient(WebPermissionClient*);
@@ -582,7 +583,7 @@ private:
DragOver
};
- WebViewImpl(WebViewClient*);
+ explicit WebViewImpl(WebViewClient*);
virtual ~WebViewImpl();
WebTextInputType textInputType();

Powered by Google App Engine
This is Rietveld 408576698