Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Unified Diff: public/web/WebView.h

Issue 23506013: Make the embedder responsible for creating the WebFrame (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix lifetime on frame detach Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « public/web/WebFrameClient.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/web/WebView.h
diff --git a/public/web/WebView.h b/public/web/WebView.h
index a9457988aaf0eed8f7a9bc4d541cd11eb5b01525..29ef2c4b9b9adb059ab45f7ab1984cb34220200d 100644
--- a/public/web/WebView.h
+++ b/public/web/WebView.h
@@ -89,19 +89,20 @@ public:
// Initialization ------------------------------------------------------
- // Creates a WebView that is NOT yet initialized. You will need to
- // call initializeMainFrame to finish the initialization. It is valid
- // to pass null client pointers.
+ // Creates a WebView that is NOT yet initialized. You will need to
+ // call setMainFrame to finish the initialization. It is valid
+ // to pass a null client pointer.
BLINK_EXPORT static WebView* create(WebViewClient*);
// After creating a WebView, you should immediately call this method.
// You can optionally modify the settings before calling this method.
- // The WebFrameClient will receive events for the main frame and any
- // child frames. It is valid to pass a null WebFrameClient pointer.
+ // This WebFrame will receive events for the main frame and must not
+ // be null.
+ virtual void setMainFrame(WebFrame*) = 0;
+ // FIXME: Remove initializeMainFrame() after clients have migrated to
+ // setMainFrame().
virtual void initializeMainFrame(WebFrameClient*) = 0;
- virtual void initializeHelperPluginFrame(WebFrameClient*) = 0;
-
// Initializes the various client interfaces.
virtual void setAutofillClient(WebAutofillClient*) = 0;
virtual void setDevToolsAgentClient(WebDevToolsAgentClient*) = 0;
« no previous file with comments | « public/web/WebFrameClient.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698