Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(911)

Unified Diff: Source/web/tests/WebPageSerializerTest.cpp

Issue 23506013: Make the embedder responsible for creating the WebFrame (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix lifetime on frame detach Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/tests/WebPageNewSerializerTest.cpp ('k') | Source/web/tests/WebPluginContainerTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/tests/WebPageSerializerTest.cpp
diff --git a/Source/web/tests/WebPageSerializerTest.cpp b/Source/web/tests/WebPageSerializerTest.cpp
index 924b755016e4b14e09a637da2173bb83e1d7cd8a..2c110cc5adf547fdd55f112d96d01b035438760f 100644
--- a/Source/web/tests/WebPageSerializerTest.cpp
+++ b/Source/web/tests/WebPageSerializerTest.cpp
@@ -66,13 +66,15 @@ protected:
{
// Create and initialize the WebView.
m_webView = WebView::create(0);
- m_webView->initializeMainFrame(&m_webFrameClient);
+ m_mainFrame = WebFrame::create(&m_webFrameClient);
+ m_webView->setMainFrame(m_mainFrame);
}
virtual void TearDown()
{
Platform::current()->unitTestSupport()->unregisterAllMockedURLs();
m_webView->close();
+ m_mainFrame->close();
}
void registerMockedURLLoad(const std::string& url, const WebString& fileName)
@@ -107,6 +109,7 @@ protected:
private:
TestWebFrameClient m_webFrameClient;
+ WebFrame* m_mainFrame;
};
TEST_F(WebPageSerializerTest, HTMLNodes)
« no previous file with comments | « Source/web/tests/WebPageNewSerializerTest.cpp ('k') | Source/web/tests/WebPluginContainerTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698