Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2002)

Unified Diff: Source/web/tests/PageSerializerTest.cpp

Issue 23506013: Make the embedder responsible for creating the WebFrame (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix lifetime on frame detach Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/tests/ListenerLeakTest.cpp ('k') | Source/web/tests/PrerenderingTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/tests/PageSerializerTest.cpp
diff --git a/Source/web/tests/PageSerializerTest.cpp b/Source/web/tests/PageSerializerTest.cpp
index 222e2eda206da97f4524ea511932b88e9f582817..d52b563f5ee957f47af07bf62c9de48997467dd0 100644
--- a/Source/web/tests/PageSerializerTest.cpp
+++ b/Source/web/tests/PageSerializerTest.cpp
@@ -82,7 +82,8 @@ protected:
settings->setLoadsImagesAutomatically(true);
settings->setJavaScriptEnabled(true);
- m_webViewImpl->initializeMainFrame(&m_webFrameClient);
+ m_mainFrame = WebFrame::create(&m_webFrameClient);
+ m_webViewImpl->setMainFrame(m_mainFrame);
}
virtual void TearDown()
@@ -90,6 +91,8 @@ protected:
Platform::current()->unitTestSupport()->unregisterAllMockedURLs();
m_webViewImpl->close();
m_webViewImpl = 0;
+ m_mainFrame->close();
+ m_mainFrame = 0;
}
void setBaseUrl(const char* url)
@@ -174,6 +177,7 @@ protected:
private:
TestWebFrameClient m_webFrameClient;
+ WebFrame* m_mainFrame;
WebString m_folder;
KURL m_baseUrl;
Vector<SerializedResource> m_resources;
« no previous file with comments | « Source/web/tests/ListenerLeakTest.cpp ('k') | Source/web/tests/PrerenderingTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698