Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Unified Diff: Source/web/tests/AssociatedURLLoaderTest.cpp

Issue 23506013: Make the embedder responsible for creating the WebFrame (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix lifetime on frame detach Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/WebViewImpl.cpp ('k') | Source/web/tests/ChromeClientImplTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/tests/AssociatedURLLoaderTest.cpp
diff --git a/Source/web/tests/AssociatedURLLoaderTest.cpp b/Source/web/tests/AssociatedURLLoaderTest.cpp
index 9ef5e3814944dc1f50eecd5f0a0a2aaa50191eb2..7795ef0841b4e9d82d287e512c0cd5960ea3b563 100644
--- a/Source/web/tests/AssociatedURLLoaderTest.cpp
+++ b/Source/web/tests/AssociatedURLLoaderTest.cpp
@@ -91,7 +91,8 @@ public:
void SetUp()
{
m_webView = WebView::create(0);
- m_webView->initializeMainFrame(&m_webFrameClient);
+ m_mainFrame = WebFrame::create(&m_webFrameClient);
+ m_webView->setMainFrame(m_mainFrame);
std::string urlRoot = "http://www.test.com/";
WebCore::KURL url = RegisterMockedUrl(urlRoot, "iframes_test.html");
@@ -117,6 +118,7 @@ public:
{
Platform::current()->unitTestSupport()->unregisterAllMockedURLs();
m_webView->close();
+ m_mainFrame->close();
}
void serveRequests()
@@ -274,6 +276,7 @@ protected:
WTF::String m_frameFilePath;
TestWebFrameClient m_webFrameClient;
WebView* m_webView;
+ WebFrame* m_mainFrame;
WebURLLoader* m_expectedLoader;
WebURLResponse m_actualResponse;
« no previous file with comments | « Source/web/WebViewImpl.cpp ('k') | Source/web/tests/ChromeClientImplTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698