Source/web/WebViewImpl.h - Issue 23506013: Make the embedder responsible for creating the WebFrame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebViewImpl.h

Issue 23506013: Make the embedder responsible for creating the WebFrame (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix lifetime on frame detach Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebViewImpl.h

diff --git a/Source/web/WebViewImpl.h b/Source/web/WebViewImpl.h

index 7e96a978da8417940d0a70fb24b221e9f87cbdea..9abced664c834e2ddcef545bdb457f60087c77e3 100644

--- a/Source/web/WebViewImpl.h

+++ b/Source/web/WebViewImpl.h

@@ -128,6 +128,7 @@ class WebViewImpl : public WebView

, public WebCore::PagePopupDriver

, public PageWidgetEventHandler {

public:

+ static WebViewImpl* create(WebViewClient*);

// WebWidget methods:

virtual void close();

@@ -181,8 +182,8 @@ public:

virtual void didExitCompositingMode();

// WebView methods:

+ virtual void setMainFrame(WebFrame*);

virtual void initializeMainFrame(WebFrameClient*);

- virtual void initializeHelperPluginFrame(WebFrameClient*);

virtual void setAutofillClient(WebAutofillClient*);

virtual void setDevToolsAgentClient(WebDevToolsAgentClient*);

virtual void setPermissionClient(WebPermissionClient*);

@@ -584,7 +585,7 @@ private:

DragOver

};

- WebViewImpl(WebViewClient*);

+ explicit WebViewImpl(WebViewClient*);

virtual ~WebViewImpl();

WebTextInputType textInputType();

« no previous file with comments | « Source/web/WebSharedWorkerImpl.cpp ('k') | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »