Source/web/WebHelperPluginImpl.h - Issue 23506013: Make the embedder responsible for creating the WebFrame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebHelperPluginImpl.h

Issue 23506013: Make the embedder responsible for creating the WebFrame (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix lifetime on frame detach Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebHelperPluginImpl.h

diff --git a/Source/web/WebHelperPluginImpl.h b/Source/web/WebHelperPluginImpl.h

index 0b06b32aa19a3ab5c9d210661cf2b09385cb08f5..d7ed9d3ebabd36b7437235991530e3ad8c70ed5a 100644

--- a/Source/web/WebHelperPluginImpl.h

+++ b/Source/web/WebHelperPluginImpl.h

@@ -43,7 +43,7 @@ namespace WebKit {

class HelperPluginChromeClient;

class WebDocument;

-class WebFrame;

+class WebFrameImpl;

class WebViewImpl;

class WebWidgetClient;

@@ -75,6 +75,7 @@ private:

WebWidgetClient* m_widgetClient;

WebViewImpl* m_webView;

+ WebFrameImpl* m_mainFrame;

OwnPtr<WebCore::Page> m_page;

OwnPtr<HelperPluginChromeClient> m_chromeClient;

« no previous file with comments | « Source/web/WebFrameImpl.cpp ('k') | Source/web/WebHelperPluginImpl.cpp » ('j') | no next file with comments »