Make the embedder responsible for creating the WebFrame

Source/web/tests/FrameTestHelpers.h

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 13 matching lines @@
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef FrameTestHelpers_h
 #define FrameTestHelpers_h
 
+#include "WebViewImpl.h"
+#include "wtf/PassOwnPtr.h"
 #include <string>

[dcheng, 2013/09/20 02:29:59]

Hm... should #include <string> be at the top of the includes?

[awong, 2013/09/20 23:57:14]

I have no clue. This is what passed the blink style checks. I can move it back
up, and the --bypass-hooks on upload.

-#include "wtf/PassOwnPtr.h"
 
 namespace WebKit {
 
-class WebFrame;
+class WebFrameImpl;
 class WebFrameClient;
-class WebView;
+class WebSettings;
 class WebViewClient;
 
 namespace FrameTestHelpers {
 
 void loadFrame(WebFrame*, const std::string& url);
+void runPendingTasks();
 
-WebView* createWebView(bool enableJavascript = false, WebFrameClient* = 0, WebViewClient* = 0);
-WebView* createWebViewAndLoad(const std::string& url, bool enableJavascript = false, WebFrameClient* = 0, WebViewClient* = 0);
+// Convenience class for handling the lifetime of a WebView and its associated mainframe in tests.
+class WebViewHelper {

[dcheng, 2013/09/20 02:29:59]

WTF_MAKE_NONCOPYABLE?

[awong, 2013/09/20 23:57:14]

Done.

+public:
+    WebViewHelper();
+    ~WebViewHelper();
 
-void runPendingTasks();
+    // Creates and initializes the WebView. Implicitly calls reset() first. IF a
+    // WebFrameClient or a WebViewClient are passed in, they must outlive the
+    // WebViewHelper.
+    WebViewImpl* initialize(bool enableJavascript = false, WebFrameClient* = 0, WebViewClient* = 0, void (*updateSettingsFunc)(WebSettings*) = 0);
+
+    // Same as initialize() but also performs the initial load of the url.
+    WebViewImpl* initializeAndLoad(const std::string& url, bool enableJavascript = false, WebFrameClient* = 0, WebViewClient* = 0, void (*updateSettingsFunc)(WebSettings*) = 0);
+
+    void reset();
+
+    WebView* webView() const { return m_webView; }
+    WebViewImpl* webViewImpl() const { return m_webView; }
+
+private:
+    WebFrameImpl* m_mainFrame;
+    WebViewImpl* m_webView;
+};
 
 } // namespace FrameTestHelpers
 } // namespace WebKit
 
 #endif // FrameTestHelpers_h