Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(882)

Side by Side Diff: public/web/WebFrameClient.h

Issue 23506013: Make the embedder responsible for creating the WebFrame (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix lifetime on frame detach Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « public/web/WebFrame.h ('k') | public/web/WebView.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 103
104 104
105 // General notifications ----------------------------------------------- 105 // General notifications -----------------------------------------------
106 106
107 // Indicates that another page has accessed the DOM of the initial empty 107 // Indicates that another page has accessed the DOM of the initial empty
108 // document of a main frame. After this, it is no longer safe to show a 108 // document of a main frame. After this, it is no longer safe to show a
109 // pending navigation's URL, because a URL spoof is possible. 109 // pending navigation's URL, because a URL spoof is possible.
110 virtual void didAccessInitialDocument(WebFrame*) { } 110 virtual void didAccessInitialDocument(WebFrame*) { }
111 111
112 // A child frame was created in this frame. This is called when the frame 112 // A child frame was created in this frame. This is called when the frame
113 // is created and initialized. 113 // is created and initialized. Takes the name of the new frame, the parent
114 // frame and returns a new WebFrame. The WebFrame is considered in-use
115 // until frameDetached() is called on it.
116 virtual WebFrame* createChildFrame(WebFrame* parent, const WebString& frameN ame) { return 0; }
117 // FIXME: Remove when all embedders use createChildFrame().
114 virtual void didCreateFrame(WebFrame* parent, WebFrame* child) { } 118 virtual void didCreateFrame(WebFrame* parent, WebFrame* child) { }
115 119
116 // This frame set its opener to null, disowning it. 120 // This frame set its opener to null, disowning it.
117 // See http://html.spec.whatwg.org/#dom-opener. 121 // See http://html.spec.whatwg.org/#dom-opener.
118 virtual void didDisownOpener(WebFrame*) { } 122 virtual void didDisownOpener(WebFrame*) { }
119 123
120 // This frame has been detached from the view, but has not been closed yet. 124 // This frame has been detached from the view, but has not been closed yet.
121 virtual void frameDetached(WebFrame*) { } 125 virtual void frameDetached(WebFrame*) { }
122 126
123 // This frame is about to be closed. This is called after frameDetached, 127 // This frame is about to be closed. This is called after frameDetached,
(...skipping 243 matching lines...) Expand 10 before | Expand all | Expand 10 after
367 // Extensions3D.h in WebCore/platform/graphics). 371 // Extensions3D.h in WebCore/platform/graphics).
368 virtual void didLoseWebGLContext(WebFrame*, int) { } 372 virtual void didLoseWebGLContext(WebFrame*, int) { }
369 373
370 protected: 374 protected:
371 ~WebFrameClient() { } 375 ~WebFrameClient() { }
372 }; 376 };
373 377
374 } // namespace WebKit 378 } // namespace WebKit
375 379
376 #endif 380 #endif
OLDNEW
« no previous file with comments | « public/web/WebFrame.h ('k') | public/web/WebView.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698