Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1686)

Side by Side Diff: Source/web/tests/RenderLayerBackingTest.cpp

Issue 23506013: Make the embedder responsible for creating the WebFrame (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix lifetime on frame detach Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/web/tests/ProgrammaticScrollTest.cpp ('k') | Source/web/tests/RenderTableCellTest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 class MockWebFrameClient : public WebFrameClient { 68 class MockWebFrameClient : public WebFrameClient {
69 }; 69 };
70 70
71 class RenderLayerBackingTest : public testing::Test { 71 class RenderLayerBackingTest : public testing::Test {
72 public: 72 public:
73 RenderLayerBackingTest() 73 RenderLayerBackingTest()
74 : m_baseURL("http://www.test.com/") 74 : m_baseURL("http://www.test.com/")
75 { 75 {
76 // We cannot reuse FrameTestHelpers::createWebViewAndLoad here because t he compositing 76 // We cannot reuse FrameTestHelpers::createWebViewAndLoad here because t he compositing
77 // settings need to be set before the page is loaded. 77 // settings need to be set before the page is loaded.
78 m_mainFrame = WebFrame::create(&m_mockWebFrameClient);
78 m_webViewImpl = toWebViewImpl(WebView::create(&m_mockWebViewClient)); 79 m_webViewImpl = toWebViewImpl(WebView::create(&m_mockWebViewClient));
79 m_webViewImpl->settings()->setForceCompositingMode(true); 80 m_webViewImpl->settings()->setForceCompositingMode(true);
80 m_webViewImpl->settings()->setAcceleratedCompositingEnabled(true); 81 m_webViewImpl->settings()->setAcceleratedCompositingEnabled(true);
81 m_webViewImpl->settings()->setAcceleratedCompositingForFixedPositionEnab led(true); 82 m_webViewImpl->settings()->setAcceleratedCompositingForFixedPositionEnab led(true);
82 m_webViewImpl->settings()->setAcceleratedCompositingForOverflowScrollEna bled(true); 83 m_webViewImpl->settings()->setAcceleratedCompositingForOverflowScrollEna bled(true);
83 m_webViewImpl->settings()->setAcceleratedCompositingForScrollableFramesE nabled(true); 84 m_webViewImpl->settings()->setAcceleratedCompositingForScrollableFramesE nabled(true);
84 m_webViewImpl->settings()->setCompositedScrollingForFramesEnabled(true); 85 m_webViewImpl->settings()->setCompositedScrollingForFramesEnabled(true);
85 m_webViewImpl->settings()->setFixedPositionCreatesStackingContext(true); 86 m_webViewImpl->settings()->setFixedPositionCreatesStackingContext(true);
86 m_webViewImpl->initializeMainFrame(&m_mockWebFrameClient); 87 m_webViewImpl->setMainFrame(m_mainFrame);
87 m_webViewImpl->resize(IntSize(320, 240)); 88 m_webViewImpl->resize(IntSize(320, 240));
88 } 89 }
89 90
90 virtual void TearDown() 91 virtual void TearDown()
91 { 92 {
92 Platform::current()->unitTestSupport()->unregisterAllMockedURLs(); 93 Platform::current()->unitTestSupport()->unregisterAllMockedURLs();
93 m_webViewImpl->close(); 94 m_webViewImpl->close();
95 m_mainFrame->close();
94 } 96 }
95 97
96 void navigateTo(const std::string& url) 98 void navigateTo(const std::string& url)
97 { 99 {
98 FrameTestHelpers::loadFrame(m_webViewImpl->mainFrame(), url); 100 FrameTestHelpers::loadFrame(m_webViewImpl->mainFrame(), url);
99 Platform::current()->unitTestSupport()->serveAsynchronousMockedRequests( ); 101 Platform::current()->unitTestSupport()->serveAsynchronousMockedRequests( );
100 } 102 }
101 103
102 void registerMockedHttpURLLoad(const std::string& fileName) 104 void registerMockedHttpURLLoad(const std::string& fileName)
103 { 105 {
104 URLTestHelpers::registerMockedURLFromBaseURL(WebString::fromUTF8(m_baseU RL.c_str()), WebString::fromUTF8(fileName.c_str())); 106 URLTestHelpers::registerMockedURLFromBaseURL(WebString::fromUTF8(m_baseU RL.c_str()), WebString::fromUTF8(fileName.c_str()));
105 } 107 }
106 108
107 protected: 109 protected:
108 std::string m_baseURL; 110 std::string m_baseURL;
109 MockWebFrameClient m_mockWebFrameClient; 111 MockWebFrameClient m_mockWebFrameClient;
110 MockWebViewClient m_mockWebViewClient; 112 MockWebViewClient m_mockWebViewClient;
111 WebViewImpl* m_webViewImpl; 113 WebViewImpl* m_webViewImpl;
114 WebFrame* m_mainFrame;
112 }; 115 };
113 116
114 TEST_F(RenderLayerBackingTest, DISABLED_GraphicsLayerBackgroundColor) 117 TEST_F(RenderLayerBackingTest, DISABLED_GraphicsLayerBackgroundColor)
115 { 118 {
116 registerMockedHttpURLLoad("layer_background_color.html"); 119 registerMockedHttpURLLoad("layer_background_color.html");
117 navigateTo(m_baseURL + "layer_background_color.html"); 120 navigateTo(m_baseURL + "layer_background_color.html");
118 m_webViewImpl->layout(); 121 m_webViewImpl->layout();
119 122
120 Document* document = m_webViewImpl->mainFrameImpl()->frame()->document(); 123 Document* document = m_webViewImpl->mainFrameImpl()->frame()->document();
121 Element* layerElement = document->getElementById("layer"); 124 Element* layerElement = document->getElementById("layer");
122 RenderLayerModelObject* renderer = toRenderLayerModelObject(layerElement->re nderer()); 125 RenderLayerModelObject* renderer = toRenderLayerModelObject(layerElement->re nderer());
123 EXPECT_EQ(renderer->style()->visitedDependentColor(CSSPropertyBackgroundColo r), 126 EXPECT_EQ(renderer->style()->visitedDependentColor(CSSPropertyBackgroundColo r),
124 renderer->layer()->backing()->graphicsLayer()->backgroundColor()); 127 renderer->layer()->backing()->graphicsLayer()->backgroundColor());
125 128
126 layerElement = document->getElementById("layer-solid-color"); 129 layerElement = document->getElementById("layer-solid-color");
127 renderer = toRenderLayerModelObject(layerElement->renderer()); 130 renderer = toRenderLayerModelObject(layerElement->renderer());
128 // RenderLayerBacking::graphicsLayer's background color is unset if SolidCol orLayer is created. 131 // RenderLayerBacking::graphicsLayer's background color is unset if SolidCol orLayer is created.
129 EXPECT_EQ(Color(), renderer->layer()->backing()->graphicsLayer()->background Color()); 132 EXPECT_EQ(Color(), renderer->layer()->backing()->graphicsLayer()->background Color());
130 } 133 }
131 134
132 } 135 }
133 136
134 } // namespace WebCore 137 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/web/tests/ProgrammaticScrollTest.cpp ('k') | Source/web/tests/RenderTableCellTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698