Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Side by Side Diff: Source/web/tests/FrameTestHelpers.h

Issue 23506013: Make the embedder responsible for creating the WebFrame (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix lifetime on frame detach Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/web/tests/FrameLoaderClientImplTest.cpp ('k') | Source/web/tests/FrameTestHelpers.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 13 matching lines...) Expand all
24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #ifndef FrameTestHelpers_h 31 #ifndef FrameTestHelpers_h
32 #define FrameTestHelpers_h 32 #define FrameTestHelpers_h
33 33
34 #include "WebViewImpl.h"
35 #include "wtf/PassOwnPtr.h"
34 #include <string> 36 #include <string>
35 #include "wtf/PassOwnPtr.h"
36 37
37 namespace WebKit { 38 namespace WebKit {
38 39
39 class WebFrame; 40 class WebFrameImpl;
40 class WebFrameClient; 41 class WebFrameClient;
41 class WebView; 42 class WebSettings;
42 class WebViewClient; 43 class WebViewClient;
43 44
44 namespace FrameTestHelpers { 45 namespace FrameTestHelpers {
45 46
46 void loadFrame(WebFrame*, const std::string& url); 47 void loadFrame(WebFrame*, const std::string& url);
48 void runPendingTasks();
47 49
48 WebView* createWebView(bool enableJavascript = false, WebFrameClient* = 0, WebVi ewClient* = 0); 50 // Convenience class for handling the lifetime of a WebView and its associated m ainframe in tests.
49 WebView* createWebViewAndLoad(const std::string& url, bool enableJavascript = fa lse, WebFrameClient* = 0, WebViewClient* = 0); 51 class WebViewHelper {
52 WTF_MAKE_NONCOPYABLE(WebViewHelper);
53 public:
54 WebViewHelper();
55 ~WebViewHelper();
50 56
51 void runPendingTasks(); 57 // Creates and initializes the WebView. Implicitly calls reset() first. IF a
58 // WebFrameClient or a WebViewClient are passed in, they must outlive the
59 // WebViewHelper.
60 WebViewImpl* initialize(bool enableJavascript = false, WebFrameClient* = 0, WebViewClient* = 0, void (*updateSettingsFunc)(WebSettings*) = 0);
61
62 // Same as initialize() but also performs the initial load of the url.
63 WebViewImpl* initializeAndLoad(const std::string& url, bool enableJavascript = false, WebFrameClient* = 0, WebViewClient* = 0, void (*updateSettingsFunc)(We bSettings*) = 0);
64
65 void reset();
66
67 WebView* webView() const { return m_webView; }
68 WebViewImpl* webViewImpl() const { return m_webView; }
69
70 private:
71 WebFrameImpl* m_mainFrame;
72 WebViewImpl* m_webView;
73 };
52 74
53 } // namespace FrameTestHelpers 75 } // namespace FrameTestHelpers
54 } // namespace WebKit 76 } // namespace WebKit
55 77
56 #endif // FrameTestHelpers_h 78 #endif // FrameTestHelpers_h
OLDNEW
« no previous file with comments | « Source/web/tests/FrameLoaderClientImplTest.cpp ('k') | Source/web/tests/FrameTestHelpers.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698