Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2350583002: Starting work on full GN build (Closed)

Created:
4 years, 3 months ago by zra
Modified:
4 years, 3 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Starting work on full GN build This change: - Sucks in gn binaries - Sucks in a version of llvm that the GN build likes - Adds tools/gn.py to invoke gn - Adds a root BUILD.gn and .gn file - Removes chrome boilerplate we don't need - etc. This lets us do a standalone build of the 'runtime' target for x64, ia32, arm, arm64, mips, and the simulators on Linux, and arm and arm64 on Android. It does not include tcmalloc, and hasn't been tested on Mac or Windows. That work and more cleanup of chrome boilerplate will come in follow-up CLs. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/7e1b7e54d735c53af048174f31a49153c678b553

Patch Set 1 #

Patch Set 2 : Cleanup #

Patch Set 3 : Cleanup #

Total comments: 10

Patch Set 4 : Address comments #

Patch Set 5 : . #

Patch Set 6 : Fixes for Fuchsia and Flutter. Cleanup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2612 lines, -5634 lines) Patch
A .gn View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
A BUILD.gn View 1 1 chunk +21 lines, -0 lines 0 comments Download
M DEPS View 1 2 3 4 5 5 chunks +86 lines, -8 lines 0 comments Download
M build/config/BUILD.gn View 1 2 1 chunk +9 lines, -419 lines 0 comments Download
M build/config/BUILDCONFIG.gn View 1 2 15 chunks +113 lines, -465 lines 0 comments Download
D build/config/allocator.gni View 1 2 1 chunk +0 lines, -16 lines 0 comments Download
M build/config/android/config.gni View 1 chunk +1 line, -3 lines 0 comments Download
D build/config/chrome_build.gni View 1 2 1 chunk +0 lines, -19 lines 0 comments Download
M build/config/clang/clang.gni View 1 1 chunk +1 line, -1 line 0 comments Download
M build/config/compiler/BUILD.gn View 1 2 26 chunks +29 lines, -351 lines 0 comments Download
D build/config/crypto.gni View 1 2 1 chunk +0 lines, -29 lines 0 comments Download
D build/config/features.gni View 1 2 1 chunk +0 lines, -204 lines 0 comments Download
M build/config/linux/BUILD.gn View 1 2 2 chunks +0 lines, -41 lines 0 comments Download
M build/config/sysroot.gni View 1 2 2 chunks +0 lines, -22 lines 0 comments Download
D build/config/ui.gni View 1 2 1 chunk +0 lines, -68 lines 0 comments Download
M build/config/win/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
D build/gyp_chromium View 1 2 3 4 5 1 chunk +0 lines, -333 lines 0 comments Download
D build/gyp_chromium.py View 1 2 3 4 5 1 chunk +0 lines, -18 lines 0 comments Download
D build/gyp_chromium_test.py View 1 2 3 4 5 1 chunk +0 lines, -66 lines 0 comments Download
D build/json_schema_api.gni View 1 2 1 chunk +0 lines, -242 lines 0 comments Download
D build/json_schema_bundle_compile.gypi View 1 2 1 chunk +0 lines, -83 lines 0 comments Download
D build/json_schema_bundle_registration_compile.gypi View 1 2 1 chunk +0 lines, -78 lines 0 comments Download
D build/json_schema_compile.gypi View 1 2 1 chunk +0 lines, -123 lines 0 comments Download
D build/json_to_struct.gypi View 1 2 1 chunk +0 lines, -53 lines 0 comments Download
D build/module_args/dart.gni View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
D build/module_args/mojo.gni View 1 2 1 chunk +0 lines, -16 lines 0 comments Download
D build/module_args/nacl.gni View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
D build/module_args/v8.gni View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
D build/secondary/testing/gmock/BUILD.gn View 1 1 chunk +0 lines, -54 lines 0 comments Download
D build/secondary/testing/gtest/BUILD.gn View 1 1 chunk +0 lines, -135 lines 0 comments Download
D build/secondary/third_party/libjpeg_turbo/BUILD.gn View 1 1 chunk +0 lines, -221 lines 0 comments Download
D build/secondary/third_party/libsrtp/BUILD.gn View 1 1 chunk +0 lines, -391 lines 0 comments Download
D build/secondary/third_party/nss/BUILD.gn View 1 1 chunk +0 lines, -1211 lines 0 comments Download
D build/secondary/tools/grit/BUILD.gn View 1 1 chunk +0 lines, -27 lines 0 comments Download
D build/secondary/tools/grit/grit_rule.gni View 1 1 chunk +0 lines, -483 lines 0 comments Download
D build/secondary/tools/grit/repack.gni View 1 1 chunk +0 lines, -47 lines 0 comments Download
D build/secondary/tools/grit/stamp_grit_sources.py View 1 1 chunk +0 lines, -55 lines 0 comments Download
D build/toolchain/fnl/BUILD.gn View 1 chunk +0 lines, -24 lines 0 comments Download
M build/toolchain/linux/BUILD.gn View 1 5 chunks +30 lines, -22 lines 0 comments Download
M runtime/BUILD.gn View 1 2 3 4 5 8 chunks +127 lines, -35 lines 0 comments Download
M runtime/bin/BUILD.gn View 1 2 3 4 5 18 chunks +337 lines, -192 lines 0 comments Download
M runtime/bin/bin.gypi View 1 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/bin/builtin.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M runtime/bin/builtin.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M runtime/bin/zlib.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
A runtime/bin/zlib/BUILD.gn View 1 2 1 chunk +56 lines, -0 lines 0 comments Download
M runtime/observatory/BUILD.gn View 1 2 3 4 6 chunks +62 lines, -30 lines 0 comments Download
M runtime/vm/BUILD.gn View 1 2 3 4 5 7 chunks +58 lines, -11 lines 0 comments Download
A tools/clang/scripts/update.py View 1 1 chunk +771 lines, -0 lines 0 comments Download
A tools/clang/scripts/update.sh View 1 1 chunk +724 lines, -0 lines 0 comments Download
A tools/gn.py View 1 2 3 4 5 1 chunk +159 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
zra
We can probably start reviewing this. There's some work by Fuchsia folks that needs to ...
4 years, 3 months ago (2016-09-21 18:32:25 UTC) #4
Cutch
https://codereview.chromium.org/2350583002/diff/40001/runtime/BUILD.gn File runtime/BUILD.gn (right): https://codereview.chromium.org/2350583002/diff/40001/runtime/BUILD.gn#newcode183 runtime/BUILD.gn:183: static_library("libdart") { "libdart" and "libdart_precompiled_runtime" can be put behind ...
4 years, 3 months ago (2016-09-21 23:26:27 UTC) #5
zra
https://codereview.chromium.org/2350583002/diff/40001/runtime/BUILD.gn File runtime/BUILD.gn (right): https://codereview.chromium.org/2350583002/diff/40001/runtime/BUILD.gn#newcode183 runtime/BUILD.gn:183: static_library("libdart") { On 2016/09/21 23:26:27, Cutch wrote: > "libdart" ...
4 years, 3 months ago (2016-09-22 06:08:17 UTC) #6
Cutch
lgtm
4 years, 3 months ago (2016-09-22 15:51:16 UTC) #7
zra
4 years, 3 months ago (2016-09-23 14:47:41 UTC) #9
Message was sent while issue was closed.
Committed patchset #6 (id:100001) manually as
7e1b7e54d735c53af048174f31a49153c678b553 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698