Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2350553002:
Updated background color for extensions page using MD default styles. (Closed)
|
Created:
4 years, 3 months ago by Tobias E Cardenas Modified:
4 years, 3 months ago Reviewers:
Devlin CC:
chromium-reviews, chromium-apps-reviews_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUpdated background color for extensions page using MD default styles.
BUG=529395
Committed: https://crrev.com/380781df006f61955120c4ad313768c0b9bf5771
Cr-Commit-Position: refs/heads/master@{#419601}
Patch Set 1 #
Messages
Total messages: 21 (13 generated)
Description was changed from ========== Updated background color for extensions page using MD default styles. BUG= ========== to ========== Updated background color for extensions page using MD default styles. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by tobiase@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
tobiase@chromium.org changed reviewers: + rdevlin.cronin@chromium.org
Please review my first small change :)
lgtm! One thing: please update your CL description to be BUG=529395 (crbug.com/529395 is the tracking bug for all MD extensions work.)
Description was changed from ========== Updated background color for extensions page using MD default styles. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== BUG=529395 ==========
The CQ bit was checked by tobiase@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
On 2016/09/19 18:42:45, Devlin wrote: > lgtm! > > One thing: please update your CL description to be > BUG=529395 > > (crbug.com/529395 is the tracking bug for all MD extensions work.) Sorry, should have been more clear - I meant adding the bug link, rather than having that be the only content. :) Descriptions in Rietveld: [First Line - becomes the title] [CL Body] BUG=[Bug number] Given a small enough CL (this would qualify), the [CL Body] section could be omitted if it can be summarized in the one-line title.
Description was changed from ========== BUG=529395 ========== to ========== Updated background color for extensions page using MD default styles. BUG=529395 ==========
The CQ bit was checked by tobiase@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Updated background color for extensions page using MD default styles. BUG=529395 ========== to ========== Updated background color for extensions page using MD default styles. BUG=529395 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Updated background color for extensions page using MD default styles. BUG=529395 ========== to ========== Updated background color for extensions page using MD default styles. BUG=529395 Committed: https://crrev.com/380781df006f61955120c4ad313768c0b9bf5771 Cr-Commit-Position: refs/heads/master@{#419601} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/380781df006f61955120c4ad313768c0b9bf5771 Cr-Commit-Position: refs/heads/master@{#419601} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
