chromeos; Remove unused switch --dbus-unstub-clients / --dbus-real-clients

chromeos; Remove unused switch --dbus-unstub-clients / --dbus-real-clients

These are unused in the chromium and chromiumos source trees and no one on
the mailing list is actually using them. Remove them significantly simplifies
D-Bus client initialization -- only the D-Bus thread creation needs to stay
centralized.

* Remove DBusClientTypes and the string representations of them
* Delete the parser for the switch
* Initialize the client bundles as either all real or all fake
* Remove a bunch of Init/Create methods from DBusThreadManager since there
are fewer conditional cases

BUG=647367, 644414
TEST=chromeos_unittests, ash_unittests, unit_tests
TBR=tbarzic@chromium.org for easy_unlock

Committed: https://crrev.com/9be05a4b2ac43b54230f6c27711882176c377788
Cr-Commit-Position: refs/heads/master@{#419524}

[James Cook, 2016-09-17 02:23:15]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-17 02:23:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-17 02:26:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-17 02:26:16]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[James Cook, 2016-09-17 02:28:23]

jamescook@chromium.org changed reviewers:
+ stevenjb@chromium.org

[James Cook, 2016-09-17 02:28:24]

stevenjb, please take a look.

The one person who said he was using the switch actually doesn't need it -- he
has a fork of chromium and happened to tie some of his fork's additional code to
the existing switch.

This should make transitioning to a world of FooClient::Get() somewhat easier,
as we don't have to parse the switch and pass around the masks of which clients
are real or fake.

[stevenjb, 2016-09-19 16:15:56]

Makes sense. LGTM.

[James Cook, 2016-09-19 17:01:47]

jamescook@chromium.org changed reviewers:
+ sky@chromium.org

[James Cook, 2016-09-19 17:01:48]

sky, can I get a rubber-stamp for a trivial method change touching //chrome/test
?

[James Cook, 2016-09-19 17:02:06]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 17:02:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 17:39:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 17:39:36]

Dry run: This issue passed the CQ dry run.

[sky, 2016-09-19 18:04:11]

chrome/test LGTM

[James Cook, 2016-09-19 19:01:06]

Description was changed from

==========
chromeos; Remove unused switch --dbus-unstub-clients / --dbus-real-clients

These are unused in the chromium and chromiumos source trees and no one on
the mailing list is actually using them. Remove them significantly simplifies
D-Bus client initialization -- only the D-Bus thread creation needs to stay
centralized.

* Remove DBusClientTypes and the string representations of them
* Delete the parser for the switch
* Initialize the client bundles as either all real or all fake
* Remove a bunch of Init/Create methods from DBusThreadManager since there
are fewer conditional cases

BUG=647367,644414
TEST=chromeos_unittests, ash_unittests, unit_tests
==========

to

==========
chromeos; Remove unused switch --dbus-unstub-clients / --dbus-real-clients

These are unused in the chromium and chromiumos source trees and no one on
the mailing list is actually using them. Remove them significantly simplifies
D-Bus client initialization -- only the D-Bus thread creation needs to stay
centralized.

* Remove DBusClientTypes and the string representations of them
* Delete the parser for the switch
* Initialize the client bundles as either all real or all fake
* Remove a bunch of Init/Create methods from DBusThreadManager since there
are fewer conditional cases

BUG=647367,644414
TEST=chromeos_unittests, ash_unittests, unit_tests
TBR=tbarzic@chromium.org for easy_unlock
==========

[James Cook, 2016-09-19 19:02:08]

jamescook@chromium.org changed reviewers:
+ tbarzic@chromium.org

[James Cook, 2016-09-19 19:02:09]

TBR tbarzic for small refactor/rename touching
	chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api_chromeos_unittest.cc

[James Cook, 2016-09-19 19:02:22]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-09-19 19:02:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/2350543002/#ps40001
(title: "rebase again")

[commit-bot: I haz the power, 2016-09-19 19:03:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 19:10:08]

Description was changed from

==========
chromeos; Remove unused switch --dbus-unstub-clients / --dbus-real-clients

These are unused in the chromium and chromiumos source trees and no one on
the mailing list is actually using them. Remove them significantly simplifies
D-Bus client initialization -- only the D-Bus thread creation needs to stay
centralized.

* Remove DBusClientTypes and the string representations of them
* Delete the parser for the switch
* Initialize the client bundles as either all real or all fake
* Remove a bunch of Init/Create methods from DBusThreadManager since there
are fewer conditional cases

BUG=647367,644414
TEST=chromeos_unittests, ash_unittests, unit_tests
TBR=tbarzic@chromium.org for easy_unlock
==========

to

==========
chromeos; Remove unused switch --dbus-unstub-clients / --dbus-real-clients

These are unused in the chromium and chromiumos source trees and no one on
the mailing list is actually using them. Remove them significantly simplifies
D-Bus client initialization -- only the D-Bus thread creation needs to stay
centralized.

* Remove DBusClientTypes and the string representations of them
* Delete the parser for the switch
* Initialize the client bundles as either all real or all fake
* Remove a bunch of Init/Create methods from DBusThreadManager since there
are fewer conditional cases

BUG=647367,644414
TEST=chromeos_unittests, ash_unittests, unit_tests
TBR=tbarzic@chromium.org for easy_unlock
==========

[commit-bot: I haz the power, 2016-09-19 19:10:10]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-19 21:02:52]

Description was changed from

==========
chromeos; Remove unused switch --dbus-unstub-clients / --dbus-real-clients

These are unused in the chromium and chromiumos source trees and no one on
the mailing list is actually using them. Remove them significantly simplifies
D-Bus client initialization -- only the D-Bus thread creation needs to stay
centralized.

* Remove DBusClientTypes and the string representations of them
* Delete the parser for the switch
* Initialize the client bundles as either all real or all fake
* Remove a bunch of Init/Create methods from DBusThreadManager since there
are fewer conditional cases

BUG=647367,644414
TEST=chromeos_unittests, ash_unittests, unit_tests
TBR=tbarzic@chromium.org for easy_unlock
==========

to

==========
chromeos; Remove unused switch --dbus-unstub-clients / --dbus-real-clients

These are unused in the chromium and chromiumos source trees and no one on
the mailing list is actually using them. Remove them significantly simplifies
D-Bus client initialization -- only the D-Bus thread creation needs to stay
centralized.

* Remove DBusClientTypes and the string representations of them
* Delete the parser for the switch
* Initialize the client bundles as either all real or all fake
* Remove a bunch of Init/Create methods from DBusThreadManager since there
are fewer conditional cases

BUG=647367,644414
TEST=chromeos_unittests, ash_unittests, unit_tests
TBR=tbarzic@chromium.org for easy_unlock

Committed: https://crrev.com/9be05a4b2ac43b54230f6c27711882176c377788
Cr-Commit-Position: refs/heads/master@{#419524}
==========

[commit-bot: I haz the power, 2016-09-19 21:02:53]

Patchset 3 (id:??) landed as
https://crrev.com/9be05a4b2ac43b54230f6c27711882176c377788
Cr-Commit-Position: refs/heads/master@{#419524}