Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Issue 2350533002: Revert of DevTools: add devtools builder as CQ experiment (Closed)

Created:
4 years, 3 months ago by chenwilliam
Modified:
4 years, 3 months ago
Reviewers:
Sergiy Byelozyorov
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: add devtools builder as CQ experiment (patchset #1 id:1 of https://codereview.chromium.org/2324573003/ ) Reason for revert: No longer need devtools experiment. Original issue's description: > DevTools: add devtools builder as CQ experiment > > I added a builder for devtools on tryserver.chromium.linux here: > https://codereview.chromium.org/2319213002/ > > I've tried a few builds for the builder on the tryserver > and it seems to be working OK: > https://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_devtools > > BUG=642046 > > Committed: https://crrev.com/f755fc8d329167818a804a9225a32b9a389c5e50 > Cr-Commit-Position: refs/heads/master@{#417756} TBR=sergiyb@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=642046 Committed: https://crrev.com/0f2a721bf18b8b96d9f9a964520b46fdd248fa0d Cr-Commit-Position: refs/heads/master@{#420520}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M infra/config/cq.cfg View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
chenwilliam
Created Revert of DevTools: add devtools builder as CQ experiment
4 years, 3 months ago (2016-09-17 01:17:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2350533002/1
4 years, 3 months ago (2016-09-17 01:18:15 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 3 months ago (2016-09-17 01:18:17 UTC) #5
chenwilliam
PTAL, thanks.
4 years, 3 months ago (2016-09-17 01:18:47 UTC) #6
Sergiy Byelozyorov
lgtm Sorry, for the delay.
4 years, 3 months ago (2016-09-22 20:57:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2350533002/1
4 years, 3 months ago (2016-09-22 22:03:02 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-23 01:03:36 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 01:06:01 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0f2a721bf18b8b96d9f9a964520b46fdd248fa0d
Cr-Commit-Position: refs/heads/master@{#420520}

Powered by Google App Engine
This is Rietveld 408576698