Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 23505006: co19-roll to r559 (Closed)

Created:
7 years, 3 months ago by kustermann
Modified:
7 years, 3 months ago
Reviewers:
ricow1, Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+618 lines, -266 lines) Patch
M dart/tests/co19/co19-analyzer.status View 12 chunks +2 lines, -58 lines 0 comments Download
M dart/tests/co19/co19-analyzer2.status View 10 chunks +197 lines, -32 lines 0 comments Download
M dart/tests/co19/co19-co19.status View 1 8 chunks +262 lines, -24 lines 1 comment Download
M dart/tests/co19/co19-dart2dart.status View 14 chunks +12 lines, -48 lines 0 comments Download
M dart/tests/co19/co19-dart2js.status View 1 2 13 chunks +114 lines, -50 lines 0 comments Download
M dart/tests/co19/co19-runtime.status View 1 2 10 chunks +30 lines, -53 lines 0 comments Download
M deps/all.deps/DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
kustermann
7 years, 3 months ago (2013-08-28 15:52:34 UTC) #1
ricow1
lgtm
7 years, 3 months ago (2013-08-28 16:28:09 UTC) #2
kustermann
Committed patchset #3 manually as r26799 (presubmit successful).
7 years, 3 months ago (2013-08-28 16:33:00 UTC) #3
Ivan Posva
7 years, 3 months ago (2013-08-28 17:42:41 UTC) #4
Message was sent while issue was closed.
Thanks!

-Ivan

https://codereview.chromium.org/23505006/diff/5001/dart/tests/co19/co19-co19....
File dart/tests/co19/co19-co19.status (right):

https://codereview.chromium.org/23505006/diff/5001/dart/tests/co19/co19-co19....
dart/tests/co19/co19-co19.status:325: Language/15_Types/1_Static_Types_A03_t01:
Fail # co19-roll r559: Please triage this failure
Who is supposed to triage these issues in the co19-co19.status files?

Powered by Google App Engine
This is Rietveld 408576698