Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 23505003: Update autofill CC image resources. (Closed)

Created:
7 years, 3 months ago by Dane Wallinga
Modified:
7 years, 2 months ago
Reviewers:
oshima, Evan Stade
CC:
chromium-reviews, darin-cc_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Update autofill CC image resources. BUG=258626, 258649

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
A chrome/app/theme/default_100_percent/common/credit_card_cvc_hint.png View 1 2 Binary file 0 comments Download
A chrome/app/theme/default_100_percent/common/credit_card_cvc_hint_amex.png View 1 2 Binary file 0 comments Download
M chrome/app/theme/default_100_percent/credit_card_cvc_hint.png View 1 2 Binary file 0 comments Download
A chrome/app/theme/default_200_percent/common/credit_card_cvc_hint.png View 1 2 Binary file 0 comments Download
A chrome/app/theme/default_200_percent/common/credit_card_cvc_hint_amex.png View 1 2 Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/resources/default_100_percent/amex.png View Binary file 0 comments Download
M webkit/glue/resources/default_100_percent/discover.png View Binary file 0 comments Download
M webkit/glue/resources/default_100_percent/mastercard.png View Binary file 0 comments Download
M webkit/glue/resources/default_100_percent/visa.png View Binary file 0 comments Download
A webkit/glue/resources/default_200_percent/amex.png View Binary file 0 comments Download
A webkit/glue/resources/default_200_percent/discover.png View Binary file 0 comments Download
A webkit/glue/resources/default_200_percent/mastercard.png View Binary file 0 comments Download
A webkit/glue/resources/default_200_percent/visa.png View Binary file 0 comments Download

Messages

Total messages: 16 (0 generated)
Dane Wallinga
PTAL
7 years, 3 months ago (2013-08-27 17:33:21 UTC) #1
oshima
would you mind moving png files under c/a/theme/default_xxx_percent to "/common/" subdirectory?
7 years, 3 months ago (2013-08-27 17:40:51 UTC) #2
oshima
On 2013/08/27 17:40:51, oshima wrote: > would you mind moving png files under c/a/theme/default_xxx_percent to ...
7 years, 3 months ago (2013-08-27 17:43:20 UTC) #3
Dane Wallinga
On 2013/08/27 17:43:20, oshima wrote: > On 2013/08/27 17:40:51, oshima wrote: > > would you ...
7 years, 3 months ago (2013-08-27 19:05:04 UTC) #4
Evan Stade
lgtm if lg to oshima
7 years, 3 months ago (2013-08-27 19:56:06 UTC) #5
oshima
On 2013/08/27 19:05:04, Dane Wallinga wrote: > On 2013/08/27 17:43:20, oshima wrote: > > On ...
7 years, 3 months ago (2013-08-27 20:02:28 UTC) #6
Dane Wallinga
On 2013/08/27 20:02:28, oshima wrote: > On 2013/08/27 19:05:04, Dane Wallinga wrote: > > On ...
7 years, 3 months ago (2013-08-27 20:09:53 UTC) #7
oshima
On 2013/08/27 20:09:53, Dane Wallinga wrote: > On 2013/08/27 20:02:28, oshima wrote: > > On ...
7 years, 3 months ago (2013-08-27 20:12:03 UTC) #8
Evan Stade
ping Dane.
7 years, 3 months ago (2013-08-30 23:36:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgwallinga@chromium.org/23505003/28001
7 years, 3 months ago (2013-09-03 20:38:06 UTC) #10
commit-bot: I haz the power
Can't process patch for file chrome/app/theme/default_100_percent/common/credit_card_cvc_hint.png. Binary file support is temporarilly disabled due to a ...
7 years, 3 months ago (2013-09-03 20:38:09 UTC) #11
Dane Wallinga
On 2013/09/03 20:38:09, I haz the power (commit-bot) wrote: > Can't process patch for file ...
7 years, 3 months ago (2013-09-03 20:42:37 UTC) #12
Evan Stade
On 2013/09/03 20:42:37, Dane Wallinga wrote: > On 2013/09/03 20:38:09, I haz the power (commit-bot) ...
7 years, 3 months ago (2013-09-03 21:48:56 UTC) #13
Dane Wallinga
On 2013/09/03 21:48:56, Evan Stade wrote: > On 2013/09/03 20:42:37, Dane Wallinga wrote: > > ...
7 years, 3 months ago (2013-09-05 20:09:00 UTC) #14
please use gerrit instead
On 2013/09/05 20:09:00, Dane Wallinga wrote: > On 2013/09/03 21:48:56, Evan Stade wrote: > > ...
7 years, 3 months ago (2013-09-05 22:30:45 UTC) #15
Evan Stade
7 years, 3 months ago (2013-09-05 22:34:51 UTC) #16

Powered by Google App Engine
This is Rietveld 408576698