Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Unified Diff: net/socket/ssl_client_socket_impl.h

Issue 2350483002: Improve error pages on client certificate failures. (Closed)
Patch Set: curly quotes Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/error_page_strings.grdp ('k') | net/socket/ssl_client_socket_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/ssl_client_socket_impl.h
diff --git a/net/socket/ssl_client_socket_impl.h b/net/socket/ssl_client_socket_impl.h
index 3f3308c1e26f3aa51618dd748f7a76cd3eb18498..8c2482adff2094f5ffe84556a7b95102a1a5e7e2 100644
--- a/net/socket/ssl_client_socket_impl.h
+++ b/net/socket/ssl_client_socket_impl.h
@@ -37,6 +37,10 @@ class FilePath;
class SequencedTaskRunner;
}
+namespace crypto {
+class OpenSSLErrStackTracer;
+}
+
namespace net {
class CertVerifier;
@@ -248,6 +252,12 @@ class SSLClientSocketImpl : public SSLClientSocket {
// Returns whether TLS channel ID is enabled.
bool IsChannelIDEnabled() const;
+ // Returns the net error corresponding to the most recent OpenSSL
+ // error. ssl_error is the output of SSL_get_error.
+ int MapLastOpenSSLError(int ssl_error,
+ const crypto::OpenSSLErrStackTracer& tracer,
+ OpenSSLErrorInfo* info);
+
bool transport_send_busy_;
bool transport_recv_busy_;
@@ -360,6 +370,8 @@ class SSLClientSocketImpl : public SSLClientSocket {
ScopedSSL_SESSION pending_session_;
// True if the initial handshake's certificate has been verified.
bool certificate_verified_;
+ // Set to true if a CertificateRequest was received.
+ bool certificate_requested_;
// The request handle for |channel_id_service_|.
ChannelIDService::Request channel_id_request_;
« no previous file with comments | « components/error_page_strings.grdp ('k') | net/socket/ssl_client_socket_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698