Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2670)

Unified Diff: chrome/browser/resources/bookmark_manager/css/bmm.css

Issue 2350473003: Bookmark manager folder icon cleanups for list pane. (Closed)
Patch Set: Runtime check Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/bookmark_manager/css/bmm.css
diff --git a/chrome/browser/resources/bookmark_manager/css/bmm.css b/chrome/browser/resources/bookmark_manager/css/bmm.css
index 43368216b90f9f849d05b74b72fef46f584be746..0f12426e9d8415cd91d335d03d0956e9491fabbc 100644
--- a/chrome/browser/resources/bookmark_manager/css/bmm.css
+++ b/chrome/browser/resources/bookmark_manager/css/bmm.css
@@ -48,42 +48,32 @@ list > * > * {
}
list .label {
- color: black;
- display: inline-block; /* Makes the image start-align in RTL. */
+ -webkit-padding-start: 0;
+ align-items: center;
+ display: flex;
}
-html[dir=rtl] list .label {
- background-position: 100% 50%;
+list .label-img-wrapper {
+ display: inline-block; /* Makes the image start-align in RTL. */
+ width: 20px;
}
-<if expr="is_macosx">
-list > .folder > .label,
-.tree-label,
-.tree-row[may-have-children] > .tree-label,
-.tree-item[expanded] > .tree-row > .tree-label {
- background-image: -webkit-image-set(
- url(../../../../app/theme/default_100_percent/mac/bookmark_bar_folder.png) 1x,
- url(../../../../app/theme/default_200_percent/mac/bookmark_bar_folder.png) 2x);
+<if expr="not is_macosx and not is_ios">
+html[dir=rtl] list > .folder .label-img-wrapper > * {
+ transform: scaleX(-1);
}
</if>
-<if expr="not is_macosx">
-list > .folder > .label {
- background-image: -webkit-image-set(
- url(../../../../../ui/resources/default_100_percent/common/folder_closed.png) 1x,
- url(../../../../../ui/resources/default_200_percent/common/folder_closed.png) 2x);
-}
-
-html[dir=rtl] list > .folder > .label {
- background-image: -webkit-image-set(
- url(../../../../../ui/resources/default_100_percent/common/folder_closed_rtl.png) 1x,
- url(../../../../../ui/resources/default_200_percent/common/folder_closed_rtl.png) 2x);
+list .label-text {
+ color: black;
+ flex: 1;
+ overflow: hidden;
+ text-overflow: ellipsis;
}
-</if>
/* We need to ensure that even empty labels take up space, or the row could be
* the wrong height. */
-list .label:empty::after {
+list .label-text:empty::after {
content: ' ';
white-space: pre;
}
@@ -278,6 +268,18 @@ list [editing] input {
top: 2px;
}
+/* TODO(pkasting): Convert the tree widget to use the same resources as the
+ * list, and remove this block. */
+<if expr="is_macosx">
+.tree-label,
+.tree-row[may-have-children] > .tree-label,
+.tree-item[expanded] > .tree-row > .tree-label {
+ background-image: -webkit-image-set(
+ url(../../../../app/theme/default_100_percent/mac/bookmark_bar_folder.png) 1x,
+ url(../../../../app/theme/default_200_percent/mac/bookmark_bar_folder.png) 2x);
+}
+</if>
+
.splitter {
border-left: 5px solid rgb(235, 239, 249);
cursor: e-resize;
« no previous file with comments | « no previous file | chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698