Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3735)

Unified Diff: chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js

Issue 2350473003: Bookmark manager folder icon cleanups for list pane. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js
diff --git a/chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js b/chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js
index 4c8f50e43e335c20ce2b6f76956a02af9f5e8282..78e758dee27db554dc326d3c504835fc12064f9f 100644
--- a/chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js
+++ b/chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js
@@ -423,19 +423,34 @@ cr.define('bmm', function() {
var labelEl = this.ownerDocument.createElement('div');
labelEl.className = 'label';
- labelEl.textContent = bookmarkNode.title;
+ var labelImgWrapper = this.ownerDocument.createElement('div');
+ labelImgWrapper.className = 'label-img-wrapper';
+ var labelImg = this.ownerDocument.createElement('div');
+ var labelText = this.ownerDocument.createElement('div');
+ labelText.className = 'label-text';
+ labelText.textContent = bookmarkNode.title;
var urlEl = this.ownerDocument.createElement('div');
urlEl.className = 'url';
if (bmm.isFolder(bookmarkNode)) {
this.className = 'folder';
+ labelImg.style.content =
+/* TODO(pkasting): Condense folder icon resources together. */
+<if expr="is_macosx">
Dan Beam 2016/09/21 03:14:23 doing this at compile time is arguably better, but
Peter Kasting 2016/09/21 04:52:35 I didn't know! I'd actually prefer that, since it
+ cr.icon.getImage('chrome://theme/IDR_BOOKMARK_BAR_FOLDER');
+</if>
+<if expr="not is_macosx">
+ cr.icon.getImage('chrome://theme/IDR_FOLDER_CLOSED');
+</if>
} else {
- labelEl.style.backgroundImage = cr.icon.getFavicon(bookmarkNode.url);
- labelEl.style.backgroundSize = '16px';
+ labelImg.style.content = cr.icon.getFavicon(bookmarkNode.url);
urlEl.textContent = bookmarkNode.url;
}
+ labelImgWrapper.appendChild(labelImg);
+ labelEl.appendChild(labelImgWrapper);
+ labelEl.appendChild(labelText);
this.appendChild(labelEl);
this.appendChild(urlEl);

Powered by Google App Engine
This is Rietveld 408576698