Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3250)

Unified Diff: chrome/renderer/page_load_metrics/renderer_page_track_decider.cc

Issue 2350473002: [page_load_metrics] Add support for chrome:// urls and add extensions observer (Closed)
Patch Set: fix about:blank check Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/page_load_metrics/renderer_page_track_decider.cc
diff --git a/chrome/renderer/page_load_metrics/renderer_page_track_decider.cc b/chrome/renderer/page_load_metrics/renderer_page_track_decider.cc
index 861b13c351a121c6a60d991b23e97ff5e9e1a194..fadf11b5f374c6cae8b6fe47bb0396170d2e511f 100644
--- a/chrome/renderer/page_load_metrics/renderer_page_track_decider.cc
+++ b/chrome/renderer/page_load_metrics/renderer_page_track_decider.cc
@@ -26,14 +26,14 @@ bool RendererPageTrackDecider::HasCommitted() {
return true;
}
-bool RendererPageTrackDecider::IsHttpOrHttpsUrl() {
- return static_cast<GURL>(document_->url()).SchemeIsHTTPOrHTTPS();
-}
-
bool RendererPageTrackDecider::IsNewTabPageUrl() {
return SearchBouncer::GetInstance()->IsNewTabPage(document_->url());
}
+bool RendererPageTrackDecider::IsAboutBlankUrl() {
+ return document_->url().string() == "about:blank";
Bryan McQuade 2016/09/20 18:47:33 can we use https://cs.chromium.org/chromium/src/ur
Charlie Harrison 2016/09/20 22:46:23 Done.
+}
+
bool RendererPageTrackDecider::IsChromeErrorPage() {
return data_source_->hasUnreachableURL();
}

Powered by Google App Engine
This is Rietveld 408576698