Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1657)

Unified Diff: chrome/browser/page_load_metrics/observers/webui_page_load_metrics_observer.h

Issue 2350473002: [page_load_metrics] Add support for chrome:// urls and add extensions observer (Closed)
Patch Set: fix about:blank check Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/webui_page_load_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/observers/webui_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/webui_page_load_metrics_observer.h
new file mode 100644
index 0000000000000000000000000000000000000000..905613e59f255e2e50249e3368e5ec1b987d69b8
--- /dev/null
+++ b/chrome/browser/page_load_metrics/observers/webui_page_load_metrics_observer.h
@@ -0,0 +1,41 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_WEBUI_PAGE_LOAD_METRICS_OBSERVER_H_
+#define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_WEBUI_PAGE_LOAD_METRICS_OBSERVER_H_
+
+#include "base/macros.h"
+#include "chrome/browser/page_load_metrics/page_load_metrics_observer.h"
+
+namespace internal {
+
+// Exposed for testing.
+extern const char kHistogramExtensionsParseDuration[];
+
+} // namespace internal
+
+class WebUIPageLoadMetricsObserver
Bryan McQuade 2016/09/20 18:47:33 i'm not familiar with the name WebUI so this class
Charlie Harrison 2016/09/20 22:46:23 AFAIK they are all chrome:// urls, and it is indic
+ : public page_load_metrics::PageLoadMetricsObserver {
+ public:
+ WebUIPageLoadMetricsObserver();
+
+ // page_load_metrics::PageLoadMetricsObserver:
+ page_load_metrics::TrackingPolicy ShouldTrackLoad(
+ content::NavigationHandle* navigation_handle) override;
+ void OnParseStop(const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::PageLoadExtraInfo& info) override;
+ void OnFirstContentfulPaint(
+ const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::PageLoadExtraInfo& info) override;
+
+ private:
+ enum TrackedPage {
+ NONE,
+ EXTENSIONS,
+ };
+ TrackedPage tracked_page_ = NONE;
+ DISALLOW_COPY_AND_ASSIGN(WebUIPageLoadMetricsObserver);
+};
+
+#endif // CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_WEBUI_PAGE_LOAD_METRICS_OBSERVER_H_

Powered by Google App Engine
This is Rietveld 408576698