chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc - Issue 2350473002: [page_load_metrics] Add support for chrome:// urls and add extensions observer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc

Issue 2350473002: [page_load_metrics] Add support for chrome:// urls and add extensions observer (Closed)

Patch Set: use url constant Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/metrics_web_contents_observer.cc ('k') | chrome/browser/page_load_metrics/observers/webui_page_load_metrics_observer.h » ('j') | chrome/browser/page_load_metrics/observers/webui_page_load_metrics_observer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc

diff --git a/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc b/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc

index 272e405985903cc32f025bd00ce61c0ed7232b14..b39eb4b5f9cd1efa31ee52a688500c53b78b7b28 100644

--- a/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc

+++ b/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc

@@ -319,7 +319,6 @@ TEST_F(MetricsWebContentsObserverTest, DontLogIrrelevantNavigation) {

ASSERT_EQ(0, CountUpdatedTimingReported());

ASSERT_EQ(0, CountCompleteTimingReported());

- CheckErrorEvent(ERR_IPC_FROM_BAD_URL_SCHEME, 1);

CheckErrorEvent(ERR_IPC_WITH_NO_RELEVANT_LOAD, 1);

CheckTotalErrorEvents();

}