Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Unified Diff: third_party/WebKit/Source/core/input/PointerEventManager.h

Issue 2350433002: Extract more of the mouse logic from EventHandler (Closed)
Patch Set: Yet another rebase because of a presubmit rule bug Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/input/PointerEventManager.h
diff --git a/third_party/WebKit/Source/core/input/PointerEventManager.h b/third_party/WebKit/Source/core/input/PointerEventManager.h
index 3c1d73e680c824a149a92ec448a78f76a514db17..93fbbb9956be6deb5ec3e6534a3e8974b8170eec 100644
--- a/third_party/WebKit/Source/core/input/PointerEventManager.h
+++ b/third_party/WebKit/Source/core/input/PointerEventManager.h
@@ -27,7 +27,7 @@ class CORE_EXPORT PointerEventManager
WTF_MAKE_NONCOPYABLE(PointerEventManager);
public:
- explicit PointerEventManager(LocalFrame*, MouseEventManager*);
+ PointerEventManager(LocalFrame*, MouseEventManager*);
DECLARE_TRACE();
// Sends the mouse pointer events and the boundary events
@@ -36,29 +36,18 @@ class CORE_EXPORT PointerEventManager
// in this function.
WebInputEventResult sendMousePointerEvent(Node* target,
const AtomicString& type,
- int clickCount,
- const PlatformMouseEvent&,
- Node* lastNodeUnderMouse,
- Node** newNodeUnderMouse);
+ const PlatformMouseEvent&);
WebInputEventResult handleTouchEvents(const PlatformTouchEvent&);
- // Sends boundary events mouseout/leave/over/enter to the
- // corresponding targets. This function sends pointerout/leave/over/enter
- // only when isFrameBoundaryTransition is true which indicates the
- // transition is over the document boundary and not only the elements border
- // inside the document. If isFrameBoundaryTransition is false,
- // then the event is a compatibility event like those created by touch
- // and in that case the corresponding pointer events will be handled by
- // sendTouchPointerEvent for example and there is no need to send pointer
- // boundary events. Note that normal mouse events (e.g. mousemove/down/up)
+ // Sends boundary events pointerout/leave/over/enter and
+ // mouseout/leave/over/enter to the corresponding targets.
+ // inside the document. This functions handles the cases that pointer is
+ // leaving a frame. Note that normal mouse events (e.g. mousemove/down/up)
// and their corresponding boundary events will be handled altogether by
// sendMousePointerEvent function.
- void sendMouseAndPossiblyPointerBoundaryEvents(
- Node* exitedNode,
- Node* enteredNode,
- const PlatformMouseEvent&,
- bool isFrameBoundaryTransition);
+ void sendMouseAndPointerBoundaryEvents(Node* enteredNode,
+ const PlatformMouseEvent&);
// Resets the internal state of this object.
void clear();
@@ -166,10 +155,8 @@ class CORE_EXPORT PointerEventManager
EventTarget* processCaptureAndPositionOfPointerEvent(
PointerEvent*,
EventTarget* hitTestTarget,
- EventTarget* lastNodeUnderMouse = nullptr,
const PlatformMouseEvent& = PlatformMouseEvent(),
- bool sendMouseEvent = false,
- bool setPointerPosition = true);
+ bool sendMouseEvent = false);
void removeTargetFromPointerCapturingMapping(PointerCapturingMap&,
const EventTarget*);

Powered by Google App Engine
This is Rietveld 408576698