Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Unified Diff: third_party/WebKit/Source/core/input/KeyboardEventManager.cpp

Issue 2350433002: Extract more of the mouse logic from EventHandler (Closed)
Patch Set: Yet another rebase because of a presubmit rule bug Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/input/KeyboardEventManager.cpp
diff --git a/third_party/WebKit/Source/core/input/KeyboardEventManager.cpp b/third_party/WebKit/Source/core/input/KeyboardEventManager.cpp
index dcac6a6952f0986b5f7d9da32802195486e4553f..97be202fb4a440560578ff8b22145c7e0411bd57 100644
--- a/third_party/WebKit/Source/core/input/KeyboardEventManager.cpp
+++ b/third_party/WebKit/Source/core/input/KeyboardEventManager.cpp
@@ -56,6 +56,11 @@ KeyboardEventManager::KeyboardEventManager(LocalFrame* frame,
ScrollManager* scrollManager)
: m_frame(frame), m_scrollManager(scrollManager) {}
+DEFINE_TRACE(KeyboardEventManager) {
+ visitor->trace(m_frame);
+ visitor->trace(m_scrollManager);
+}
+
bool KeyboardEventManager::handleAccessKey(const WebKeyboardEvent& evt) {
// FIXME: Ignoring the state of Shift key is what neither IE nor Firefox do.
// IE matches lower and upper case access keys regardless of Shift key state - but if both upper and
@@ -310,11 +315,6 @@ void KeyboardEventManager::defaultEscapeEventHandler(KeyboardEvent* event) {
dialog->dispatchEvent(Event::createCancelable(EventTypeNames::cancel));
}
-DEFINE_TRACE(KeyboardEventManager) {
- visitor->trace(m_frame);
- visitor->trace(m_scrollManager);
-}
-
static OverrideCapsLockState s_overrideCapsLockState;
void KeyboardEventManager::setCurrentCapsLockState(
« no previous file with comments | « third_party/WebKit/Source/core/input/GestureManager.cpp ('k') | third_party/WebKit/Source/core/input/MouseEventManager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698