LayoutTests/fast/svg/different-overflow-values.html - Issue 235043003: ASSERTION FAILED: object->style()->overflowX() == object->style()->overflowY()

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/svg/different-overflow-values.html

Issue 235043003: ASSERTION FAILED: object->style()->overflowX() == object->style()->overflowY() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>
	esprehn 2014/04/12 06:22:47 We often leave off the <html>, <head> and <body>. We often leave off the <html>, <head> and <body>.
	4 <script src="../../resources/js-test.js"></script>

	5 <script type="text/javascript" charset="utf-8">
	esprehn 2014/04/12 06:22:47 Leave off type and charset. Leave off type and charset.
	6 if (window.testRunner)

	7 testRunner.dumpAsText();
	esprehn 2014/04/12 06:22:47 You don't need this, js-test.js does this. You don't need this, js-test.js does this.
	8

	9 function shouldBeEqual(a, b)
	esprehn 2014/04/12 06:22:47 js-test has this already. js-test has this already.
	10 {

	11 if (a == b)

	12 testPassed("Overflow values are the same.");

	13 else

	14 testFailed("Overflow values should be the same. overflow-x: " + a + ", overflow-y: " + b + ".");

	15 }

	16

	17 function test()
	esprehn 2014/04/12 06:22:47 onload = function() { onload = function() {
	18 {

	19 description("This test checks the overflow equality in case of SVG.")

	20

	21 var cases = document.getElementsByClassName("case");
	esprehn 2014/04/12 06:22:47 Use querySelector Use querySelector
	22 for (var i = 0; i < cases.length; ++i) {

	23 var computedStyle = getComputedStyle(cases[i]);
	esprehn 2014/04/12 06:22:47 remove var remove var
	24 var overflowX = computedStyle.getPropertyValue("overflow-x");

	25 var overflowY = computedStyle.getPropertyValue("overflow-y");
	esprehn 2014/04/12 06:22:47 remove this. remove this.
	26

	27 shouldBeEqual(overflowX, overflowY);
	esprehn 2014/04/12 06:22:47 shouldBe("computedStyle.getPropertyValue('overflow shouldBe("computedStyle.getPropertyValue('overflow-x')", "computedStyle.getPropertyValue('overflow-y')") js-test does all this for you.
	28 }

	29 }

	30 </script>

	31 </head>

	32 <body>

	33 <svg class="case"/>

	34 <svg class="case" style="overflow-x: auto"/>

	35 <svg class="case" style="overflow-x: visible; overflow-y: hidden"/>

	36 <script>

	37 test();
	esprehn 2014/04/12 06:22:47 remove remove
	38 </script>

	39 </body>

	40 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/svg/different-overflow-values-expected.txt » ('j') | no next file with comments »