Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 2350423002: [crankshaft] Remove HStoreKeyedGeneric and use HCallWithDescriptor instead to call KeyedStoreIC. (Closed)

Created:
4 years, 3 months ago by Igor Sheludko
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Remove HStoreKeyedGeneric and use HCallWithDescriptor instead to call KeyedStoreIC. ... because the latter automatically respects the desired calling convention. BUG=v8:5407 Committed: https://crrev.com/4286f2c0bd5905c9696e682758ca95794df5e1bb Cr-Commit-Position: refs/heads/master@{#39543}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -860 lines) Patch
M src/crankshaft/arm/lithium-arm.h View 2 chunks +0 lines, -29 lines 0 comments Download
M src/crankshaft/arm/lithium-arm.cc View 2 chunks +0 lines, -29 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 2 chunks +0 lines, -29 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.h View 2 chunks +0 lines, -29 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.cc View 2 chunks +0 lines, -29 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 2 chunks +0 lines, -29 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 2 chunks +21 lines, -11 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.h View 2 chunks +0 lines, -45 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 2 chunks +0 lines, -29 lines 0 comments Download
M src/crankshaft/ia32/lithium-ia32.h View 2 chunks +0 lines, -29 lines 0 comments Download
M src/crankshaft/ia32/lithium-ia32.cc View 2 chunks +0 lines, -29 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 2 chunks +0 lines, -29 lines 0 comments Download
M src/crankshaft/mips/lithium-mips.h View 2 chunks +0 lines, -29 lines 0 comments Download
M src/crankshaft/mips/lithium-mips.cc View 2 chunks +0 lines, -29 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 2 chunks +0 lines, -29 lines 0 comments Download
M src/crankshaft/mips64/lithium-mips64.h View 2 chunks +0 lines, -29 lines 0 comments Download
M src/crankshaft/mips64/lithium-mips64.cc View 2 chunks +0 lines, -29 lines 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 2 chunks +0 lines, -29 lines 0 comments Download
M src/crankshaft/ppc/lithium-ppc.h View 2 chunks +0 lines, -29 lines 0 comments Download
M src/crankshaft/ppc/lithium-ppc.cc View 2 chunks +0 lines, -29 lines 0 comments Download
M src/crankshaft/s390/lithium-codegen-s390.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/crankshaft/s390/lithium-codegen-s390.cc View 2 chunks +0 lines, -27 lines 0 comments Download
M src/crankshaft/s390/lithium-s390.h View 2 chunks +0 lines, -28 lines 0 comments Download
M src/crankshaft/s390/lithium-s390.cc View 2 chunks +0 lines, -27 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 2 chunks +0 lines, -29 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.h View 2 chunks +0 lines, -29 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.cc View 2 chunks +0 lines, -29 lines 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.cc View 2 chunks +0 lines, -29 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.h View 2 chunks +0 lines, -29 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.cc View 2 chunks +0 lines, -29 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (6 generated)
Igor Sheludko
PTAL
4 years, 3 months ago (2016-09-20 09:56:45 UTC) #4
Benedikt Meurer
LGTM.
4 years, 3 months ago (2016-09-20 10:42:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2350423002/1
4 years, 3 months ago (2016-09-20 10:43:07 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 11:11:37 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 11:12:12 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4286f2c0bd5905c9696e682758ca95794df5e1bb
Cr-Commit-Position: refs/heads/master@{#39543}

Powered by Google App Engine
This is Rietveld 408576698