Issue 235038: Fix an uninitialized memory error reported by valgrind....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 235038: Fix an uninitialized memory error reported by valgrind.... (Closed)

Created:
11 years, 2 months ago by James Su

Modified:
9 years, 7 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews_googlegroups.com, darin (slow to review)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix an uninitialized memory error reported by valgrind. In order to make valgrind happy, this CL changes WebKeyboardEvent::isSystemKey and WebMouseWheelEvent::scrollByPage to int type to make sure the size of WebKeyboardEvent and WebMouseWheelEvent align to a factor of 4 bytes strictly. BUG=22857 : Uninitialized memory sent via IPC from RenderWidgetHostViewGtkWidget::KeyPressReleaseEvent() TEST=Run chrome with valgrind and input something or scroll the mouse wheel in a web page, valgrind should not complain uninitialized memory anymore. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27451

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -2 lines)			Patch
	M	webkit/api/public/WebInputEvent.h	View		2 chunks	+11 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm!

Expand Messages | Collapse Messages