Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 2350363003: Revert of bot_update: add --auth-refresh-token-json passthrough for apply_issue (Closed)

Created:
4 years, 3 months ago by Ryan Tseng
Modified:
4 years, 3 months ago
CC:
chromium-reviews, dpranke+depot_too^s_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of bot_update: add --auth-refresh-token-json passthrough for apply_issue (patchset #7 id:120001 of https://codereview.chromium.org/2294413002/ ) Reason for revert: Pointing to the wrong file :( Original issue's description: > bot_update: add --auth-refresh-token-json passthrough for apply_issue > > BUG=642150 > > Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/e465667e78b3f898f25b64a3ec4f5c003f7554e7 TBR=vadimsh@chromium.org,martiniss@chromium.org,tandrii@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=642150 Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/ad842878e4f6a17008ac0923532bfcb88429897f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -151 lines) Patch
M recipe_modules/bot_update/api.py View 5 chunks +4 lines, -13 lines 0 comments Download
M recipe_modules/bot_update/example.py View 4 chunks +0 lines, -15 lines 0 comments Download
D recipe_modules/bot_update/example.expected/trychange_oauth2_json.json View 1 chunk +0 lines, -52 lines 0 comments Download
D recipe_modules/bot_update/example.expected/trychange_oauth2_json_win.json View 1 chunk +0 lines, -52 lines 0 comments Download
M recipe_modules/bot_update/resources/bot_update.py View 7 chunks +8 lines, -18 lines 0 comments Download
M tests/bot_update_coverage_test.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Ryan Tseng
Created Revert of bot_update: add --auth-refresh-token-json passthrough for apply_issue
4 years, 3 months ago (2016-09-20 01:08:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2350363003/1
4 years, 3 months ago (2016-09-20 01:08:29 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/depot_tools/+/ad842878e4f6a17008ac0923532bfcb88429897f
4 years, 3 months ago (2016-09-20 01:08:37 UTC) #5
tandrii(chromium)
4 years, 3 months ago (2016-09-20 01:09:35 UTC) #6
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698