Make Promise.all/Promise.race catch prediction conditional on DevTools

Make Promise.all/Promise.race catch prediction conditional on DevTools

To improve performance, this patch makes Promise.all and Promise.race not
perform correct catch prediction when the debugger is not open. The case
may come up if Promise.race or Promise.all is called, then DevTools is
open, then a component Promise is rejected. In this case, the user would
falsely get an exception event even if the "pause on caught exceptions"
box is unchecked. There are tests which triggered this case; however, it
seems both unlikely and and acceptable to have an event in this case.
Many analogous events are already produced when DevTools is enabled
during the operation of a program.

BUG=v8:3093
Committed: https://crrev.com/377358516fe422dacc26614bf94c8ad54e6cbaf2
Cr-Commit-Position: refs/heads/master@{#39565}

[Dan Ehrenberg, 2016-09-20 00:31:39]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 00:31:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Ehrenberg, 2016-09-20 00:32:11]

littledan@chromium.org changed reviewers:
+ jgruber@chromium.org

[Dan Ehrenberg, 2016-09-20 01:09:51]

littledan@chromium.org changed reviewers:
+ kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2016-09-20 01:12:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 01:12:53]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/13020)

[kozy, 2016-09-20 17:27:01]

lgtm, thanks!

[Dan Ehrenberg, 2016-09-20 19:08:32]

The CQ bit was checked by littledan@chromium.org

[commit-bot: I haz the power, 2016-09-20 19:08:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 19:33:49]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-20 19:34:46]

Description was changed from

==========
Make Promise.all/Promise.race catch prediction conditional on DevTools

To improve performance, this patch makes Promise.all and Promise.race not
perform correct catch prediction when the debugger is not open. The case
may come up if Promise.race or Promise.all is called, then DevTools is
open, then a component Promise is rejected. In this case, the user would
falsely get an exception event even if the "pause on caught exceptions"
box is unchecked. There are tests which triggered this case; however, it
seems both unlikely and and acceptable to have an event in this case.
Many analogous events are already produced when DevTools is enabled
during the operation of a program.

BUG=v8:3093
==========

to

==========
Make Promise.all/Promise.race catch prediction conditional on DevTools

To improve performance, this patch makes Promise.all and Promise.race not
perform correct catch prediction when the debugger is not open. The case
may come up if Promise.race or Promise.all is called, then DevTools is
open, then a component Promise is rejected. In this case, the user would
falsely get an exception event even if the "pause on caught exceptions"
box is unchecked. There are tests which triggered this case; however, it
seems both unlikely and and acceptable to have an event in this case.
Many analogous events are already produced when DevTools is enabled
during the operation of a program.

BUG=v8:3093

Committed: https://crrev.com/377358516fe422dacc26614bf94c8ad54e6cbaf2
Cr-Commit-Position: refs/heads/master@{#39565}
==========

[commit-bot: I haz the power, 2016-09-20 19:34:46]

Patchset 1 (id:??) landed as
https://crrev.com/377358516fe422dacc26614bf94c8ad54e6cbaf2
Cr-Commit-Position: refs/heads/master@{#39565}