Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 2350363002: Make Promise.all/Promise.race catch prediction conditional on DevTools (Closed)

Created:
4 years, 3 months ago by Dan Ehrenberg
Modified:
4 years, 3 months ago
Reviewers:
kozy, jgruber
CC:
gunasekaran, v8-reviews_googlegroups.com, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make Promise.all/Promise.race catch prediction conditional on DevTools To improve performance, this patch makes Promise.all and Promise.race not perform correct catch prediction when the debugger is not open. The case may come up if Promise.race or Promise.all is called, then DevTools is open, then a component Promise is rejected. In this case, the user would falsely get an exception event even if the "pause on caught exceptions" box is unchecked. There are tests which triggered this case; however, it seems both unlikely and and acceptable to have an event in this case. Many analogous events are already produced when DevTools is enabled during the operation of a program. BUG=v8:3093 Committed: https://crrev.com/377358516fe422dacc26614bf94c8ad54e6cbaf2 Cr-Commit-Position: refs/heads/master@{#39565}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -30 lines) Patch
M src/js/promise.js View 4 chunks +10 lines, -4 lines 0 comments Download
M test/mjsunit/es6/debug-promises/promise-all-uncaught.js View 2 chunks +13 lines, -13 lines 0 comments Download
M test/mjsunit/es6/debug-promises/promise-race-uncaught.js View 2 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Dan Ehrenberg
4 years, 3 months ago (2016-09-20 01:09:58 UTC) #5
kozy
lgtm, thanks!
4 years, 3 months ago (2016-09-20 17:27:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2350363002/1
4 years, 3 months ago (2016-09-20 19:08:43 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 19:33:49 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 19:34:46 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/377358516fe422dacc26614bf94c8ad54e6cbaf2
Cr-Commit-Position: refs/heads/master@{#39565}

Powered by Google App Engine
This is Rietveld 408576698