Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2350313004: Suppress invalid package lint errors for a Espresso dependency (Closed)

Created:
4 years, 3 months ago by jayker
Modified:
4 years, 3 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Suppress invalid package lint errors for a Espresso dependency A Espresso dependency (Dagger) throws an InvalidPackage lint error for a javax.inject reference. Further details are in the bug. BUG=648419 Committed: https://crrev.com/bdb3c2f97403a31e40dceb42dc8d4744a9cb2b45 Cr-Commit-Position: refs/heads/master@{#420494}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build/android/lint/suppressions.xml View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jayker
mikecase@chromium.org: Please review changes. jbudorick@chromium.org: Please review changes.
4 years, 3 months ago (2016-09-20 22:32:07 UTC) #2
jbudorick
lgtm
4 years, 3 months ago (2016-09-20 22:47:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2350313004/1
4 years, 3 months ago (2016-09-22 22:35:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-22 23:10:43 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 23:12:57 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bdb3c2f97403a31e40dceb42dc8d4744a9cb2b45
Cr-Commit-Position: refs/heads/master@{#420494}

Powered by Google App Engine
This is Rietveld 408576698