Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5386)

Unified Diff: chrome/browser/resources/settings/settings_main/settings_main.html

Issue 2350313003: MD Settings: Ensure all search results are visible when going back. (Closed)
Patch Set: Add test. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/settings_main/settings_main.html
diff --git a/chrome/browser/resources/settings/settings_main/settings_main.html b/chrome/browser/resources/settings/settings_main/settings_main.html
index 079e394fde105063f078ecd55252f99d56abd45c..3763a36102fe6b0b41c049902d83b80508bf551e 100644
--- a/chrome/browser/resources/settings/settings_main/settings_main.html
+++ b/chrome/browser/resources/settings/settings_main/settings_main.html
@@ -61,7 +61,8 @@
<div>$i18n{searchNoResults}</div>
<div>$i18nRaw{searchNoResultsHelp}</div>
</div>
- <template is="dom-if" if="[[showPages_.basic]]">
+ <template is="dom-if" if="[[showBasicPage_(
+ showPages_.basic, inSearchMode_)]]">
<settings-basic-page route="BASIC" prefs="{{prefs}}"
page-visibility="[[pageVisibility]]"
on-subpage-expand="onSubpageExpand_">
@@ -80,7 +81,8 @@
</paper-button>
</div>
</template>
- <template is="dom-if" if="[[showPages_.advanced]]">
+ <template is="dom-if" if="[[showAdvancedPage_(
+ showPages_.advanced, inSearchMode_)]]">
<settings-advanced-page route="ADVANCED" prefs="{{prefs}}"
page-visibility="[[pageVisibility]]"
on-subpage-expand="onSubpageExpand_">

Powered by Google App Engine
This is Rietveld 408576698