MD Settings: Ensure all search results are visible when going back.

MD Settings: Ensure all search results are visible when going back.

BUG=640120
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/b7d1b5548da0690c04817ffa6e18ea827f844998
Cr-Commit-Position: refs/heads/master@{#420096}

[dpapad, 2016-09-20 21:05:01]

Description was changed from

==========
MD Settings: Ensure all search results are visible when going back.

BUG=640120
==========

to

==========
MD Settings: Ensure all search results are visible when going back.

BUG=640120
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-09-20 22:24:27]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 22:25:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2016-09-20 22:32:14]

dpapad@chromium.org changed reviewers:
+ dbeam@chromium.org

[dpapad, 2016-09-20 22:32:15]

https://codereview.chromium.org/2350313003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_main/settings_main.js (right):

https://codereview.chromium.org/2350313003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_main/settings_main.js:284:
this.inSearchMode_ = true;
Using inSearchMode_ to force the basic and advanced pages to be force-shown
seems much more robust, than messing with the showPages_ variable itself, which
is modified by routing as well as external events (see onSubpageExpand_ callback
for example).

[dpapad, 2016-09-21 00:45:17]

dpapad@chromium.org changed reviewers:
- dbeam@chromium.org

[dpapad, 2016-09-21 00:45:17]

Discovered an issue caused by this CL, need to rework some things. Please ignore
until further notice.

[dpapad, 2016-09-21 00:51:48]

Patchset #1 (id:1) has been deleted

[dpapad, 2016-09-21 00:52:09]

dpapad@chromium.org changed reviewers:
+ dbeam@chromium.org

[dpapad, 2016-09-21 00:52:10]

Issue fixed, feel free to review.

[dpapad, 2016-09-21 01:02:42]

On 2016/09/21 at 00:52:10, dpapad wrote:
> Issue fixed, feel free to review.

My own test is failing after latest fix. Something is off, so looking at it
again, sorry for the noise.

[dpapad, 2016-09-21 01:35:30]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 01:35:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2016-09-21 02:23:18]

On 2016/09/21 at 01:02:42, dpapad wrote:
> On 2016/09/21 at 00:52:10, dpapad wrote:
> > Issue fixed, feel free to review.
> 
> My own test is failing after latest fix. Something is off, so looking at it
again, sorry for the noise.

Test fixed.

[commit-bot: I haz the power, 2016-09-21 03:17:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 03:17:12]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2016-09-21 03:31:53]

lgtm but this logic has changed so many times subtly while looking correct each
time... :(

[dpapad, 2016-09-21 17:07:51]

On 2016/09/21 at 03:31:53, dbeam wrote:
> lgtm but this logic has changed so many times subtly while looking correct
each time... :(

Actually each time it has changed it is fixing a slightly different bug (at
least that is true for the latest two changes, fixing 638915 and 640120). I
agree that settings_main.js internal state has gotten a bit complicated over
time, and perhaps there is a way of simplifying, but it is not obvious how yet.

[dpapad, 2016-09-21 17:31:20]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2016-09-21 17:32:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 17:39:14]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-09-21 17:42:03]

Description was changed from

==========
MD Settings: Ensure all search results are visible when going back.

BUG=640120
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Ensure all search results are visible when going back.

BUG=640120
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/b7d1b5548da0690c04817ffa6e18ea827f844998
Cr-Commit-Position: refs/heads/master@{#420096}
==========

[commit-bot: I haz the power, 2016-09-21 17:42:04]

Patchset 3 (id:??) landed as
https://crrev.com/b7d1b5548da0690c04817ffa6e18ea827f844998
Cr-Commit-Position: refs/heads/master@{#420096}