Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Issue 23503086: Move DropTargetEvent back to ui/base for the time being as it depends on OSExchangeData which I don… (Closed)

Created:
7 years, 3 months ago by Ben Goodger (Google)
Modified:
7 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, ben+watch_chromium.org, tfarina, jam, dcheng, joi+watch-content_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Move DropTargetEvent back to ui/base for the time being as it depends on OSExchangeData which I don't want to move. BUG=none R=sky@chromium.org TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225019

Patch Set 1 #

Patch Set 2 : Fix bustage #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase again #

Patch Set 5 : Fix windows bustage #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -38 lines) Patch
M content/browser/web_contents/web_contents_view_aura.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A ui/base/dragdrop/drop_target_event.h View 1 chunk +36 lines, -0 lines 0 comments Download
A ui/base/dragdrop/drop_target_event.cc View 1 chunk +28 lines, -0 lines 0 comments Download
M ui/events/event.h View 1 2 2 chunks +0 lines, -21 lines 0 comments Download
M ui/events/event.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M ui/events/event_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/ui.gyp View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M ui/views/view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_drag_drop_client_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_drop_target_win.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Ben Goodger (Google)
7 years, 3 months ago (2013-09-23 20:57:32 UTC) #1
sky
LGTM
7 years, 3 months ago (2013-09-23 21:22:54 UTC) #2
Ben Goodger (Google)
7 years, 3 months ago (2013-09-24 17:20:16 UTC) #3
Message was sent while issue was closed.
Committed patchset #5 manually as r225019 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698