Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 23503084: Remove control character cookie UMA stats. (Closed)

Created:
7 years, 3 months ago by jww
Modified:
7 years, 3 months ago
CC:
chromium-reviews, erikwright (departed), cbentzel+watch_chromium.org, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org
Visibility:
Public.

Description

Remove control character cookie UMA stats. BUG=238041 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224583

Patch Set 1 #

Total comments: 2

Patch Set 2 : Readded histogram entries and marked them as obsolete. #

Total comments: 4

Patch Set 3 : Un-obseleted BooleanValid in histograms #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -41 lines) Patch
M net/cookies/parsed_cookie.cc View 7 chunks +3 lines, -41 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 5 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
jww
We are done collecting the UMA stats on cookie parsing for http://crbug.com/238041 so this is ...
7 years, 3 months ago (2013-09-20 16:37:00 UTC) #1
Ilya Sherman
https://codereview.chromium.org/23503084/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/23503084/diff/1/tools/metrics/histograms/histograms.xml#oldcode1393 tools/metrics/histograms/histograms.xml:1393: -</histogram> Please mark the histograms as <obsolete> rather than ...
7 years, 3 months ago (2013-09-20 17:42:45 UTC) #2
jww
https://codereview.chromium.org/23503084/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/23503084/diff/1/tools/metrics/histograms/histograms.xml#oldcode1393 tools/metrics/histograms/histograms.xml:1393: -</histogram> On 2013/09/20 17:42:46, Ilya Sherman wrote: > Please ...
7 years, 3 months ago (2013-09-20 17:56:26 UTC) #3
Ilya Sherman
Thanks, histograms.xml lgtm w/ nit: https://codereview.chromium.org/23503084/diff/4001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/23503084/diff/4001/tools/metrics/histograms/histograms.xml#newcode19085 tools/metrics/histograms/histograms.xml:19085: + </obsolete> Nit: No ...
7 years, 3 months ago (2013-09-20 18:03:07 UTC) #4
jww
https://codereview.chromium.org/23503084/diff/4001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/23503084/diff/4001/tools/metrics/histograms/histograms.xml#newcode19085 tools/metrics/histograms/histograms.xml:19085: + </obsolete> On 2013/09/20 18:03:08, Ilya Sherman wrote: > ...
7 years, 3 months ago (2013-09-20 18:08:56 UTC) #5
Ilya Sherman
https://codereview.chromium.org/23503084/diff/4001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/23503084/diff/4001/tools/metrics/histograms/histograms.xml#newcode19085 tools/metrics/histograms/histograms.xml:19085: + </obsolete> On 2013/09/20 18:08:57, jww wrote: > On ...
7 years, 3 months ago (2013-09-20 18:10:45 UTC) #6
jww
https://codereview.chromium.org/23503084/diff/4001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/23503084/diff/4001/tools/metrics/histograms/histograms.xml#newcode19085 tools/metrics/histograms/histograms.xml:19085: + </obsolete> On 2013/09/20 18:10:45, Ilya Sherman wrote: > ...
7 years, 3 months ago (2013-09-20 18:12:45 UTC) #7
erikwright (departed)
LGTM.
7 years, 3 months ago (2013-09-20 19:46:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jww@chromium.org/23503084/11001
7 years, 3 months ago (2013-09-20 19:55:45 UTC) #9
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=81344
7 years, 3 months ago (2013-09-20 23:37:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jww@chromium.org/23503084/11001
7 years, 3 months ago (2013-09-21 00:03:46 UTC) #11
commit-bot: I haz the power
7 years, 3 months ago (2013-09-21 16:12:03 UTC) #12
Message was sent while issue was closed.
Change committed as 224583

Powered by Google App Engine
This is Rietveld 408576698