Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: Source/core/rendering/RenderTableSection.h

Issue 23503083: Table conent is rendered over the border when colspan present with rowspan. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2009 Apple Inc. All rights reserved. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2009 Apple Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 228 matching lines...) Expand 10 before | Expand all | Expand 10 after
239 239
240 virtual bool nodeAtPoint(const HitTestRequest&, HitTestResult&, const HitTes tLocation& locationInContainer, const LayoutPoint& accumulatedOffset, HitTestAct ion) OVERRIDE; 240 virtual bool nodeAtPoint(const HitTestRequest&, HitTestResult&, const HitTes tLocation& locationInContainer, const LayoutPoint& accumulatedOffset, HitTestAct ion) OVERRIDE;
241 241
242 int borderSpacingForRow(unsigned row) const { return m_grid[row].rowRenderer ? table()->vBorderSpacing() : 0; } 242 int borderSpacingForRow(unsigned row) const { return m_grid[row].rowRenderer ? table()->vBorderSpacing() : 0; }
243 243
244 void ensureRows(unsigned); 244 void ensureRows(unsigned);
245 245
246 bool rowHasOnlySpanningCells(unsigned); 246 bool rowHasOnlySpanningCells(unsigned);
247 unsigned calcRowHeightHavingOnlySpanningCells(unsigned); 247 unsigned calcRowHeightHavingOnlySpanningCells(unsigned);
248 void updateRowsHeightHavingOnlySpanningCells(RenderTableCell*, struct Spanni ngRowsHeight&); 248 void updateRowsHeightHavingOnlySpanningCells(RenderTableCell*, struct Spanni ngRowsHeight&);
249 bool isHeightNeededForRowHavingOnlySpanningCells(unsigned);
249 250
250 void populateSpanningRowsHeightFromCell(RenderTableCell*, struct SpanningRow sHeight&); 251 void populateSpanningRowsHeightFromCell(RenderTableCell*, struct SpanningRow sHeight&);
251 void distributeExtraRowSpanHeightToPercentRows(RenderTableCell*, int, int&, Vector<int>&); 252 void distributeExtraRowSpanHeightToPercentRows(RenderTableCell*, int, int&, Vector<int>&);
252 void distributeExtraRowSpanHeightToAutoRows(RenderTableCell*, int, int&, Vec tor<int>&); 253 void distributeExtraRowSpanHeightToAutoRows(RenderTableCell*, int, int&, Vec tor<int>&);
253 void distributeExtraRowSpanHeightToRemainingRows(RenderTableCell*, int, int& , Vector<int>&); 254 void distributeExtraRowSpanHeightToRemainingRows(RenderTableCell*, int, int& , Vector<int>&);
254 void distributeRowSpanHeightToRows(SpanningRenderTableCells& rowSpanCells); 255 void distributeRowSpanHeightToRows(SpanningRenderTableCells& rowSpanCells);
255 256
256 void distributeExtraLogicalHeightToPercentRows(int& extraLogicalHeight, int totalPercent); 257 void distributeExtraLogicalHeightToPercentRows(int& extraLogicalHeight, int totalPercent);
257 void distributeExtraLogicalHeightToAutoRows(int& extraLogicalHeight, unsigne d autoRowsCount); 258 void distributeExtraLogicalHeightToAutoRows(int& extraLogicalHeight, unsigne d autoRowsCount);
258 void distributeRemainingExtraLogicalHeight(int& extraLogicalHeight); 259 void distributeRemainingExtraLogicalHeight(int& extraLogicalHeight);
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
318 ASSERT_WITH_SECURITY_IMPLICATION(!object || object->isTableSection()); 319 ASSERT_WITH_SECURITY_IMPLICATION(!object || object->isTableSection());
319 return static_cast<const RenderTableSection*>(object); 320 return static_cast<const RenderTableSection*>(object);
320 } 321 }
321 322
322 // This will catch anyone doing an unnecessary cast. 323 // This will catch anyone doing an unnecessary cast.
323 void toRenderTableSection(const RenderTableSection*); 324 void toRenderTableSection(const RenderTableSection*);
324 325
325 } // namespace WebCore 326 } // namespace WebCore
326 327
327 #endif // RenderTableSection_h 328 #endif // RenderTableSection_h
OLDNEW
« no previous file with comments | « LayoutTests/platform/win/tables/mozilla/bugs/bug6304-expected.txt ('k') | Source/core/rendering/RenderTableSection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698