Source/core/platform/graphics/skia/FontCacheSkia.cpp - Issue 23503080: Pass DOM locale to Skia in FontCache::getFontDataForCharacter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/platform/graphics/skia/FontCacheSkia.cpp

Issue 23503080: Pass DOM locale to Skia in FontCache::getFontDataForCharacter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@fontcleanup

Patch Set: Pure Android only Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/platform/graphics/chromium/FontCacheAndroid.cpp ('K') | « Source/core/platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/platform/graphics/skia/FontCacheSkia.cpp

diff --git a/Source/core/platform/graphics/skia/FontCacheSkia.cpp b/Source/core/platform/graphics/skia/FontCacheSkia.cpp

index 958b60d1aca2bbe50ccf7ae2a009813e4ecb96aa..879f0bf6b478e95ea27b92781646d7934ea0ee6b 100644

--- a/Source/core/platform/graphics/skia/FontCacheSkia.cpp

+++ b/Source/core/platform/graphics/skia/FontCacheSkia.cpp

@@ -170,7 +170,14 @@ FontPlatformData* FontCache::createFontPlatformData(const FontDescription& fontD

fontDescription.computedSize(),

fontDescription.weight() >= FontWeightBold && !tf->isBold(),

fontDescription.italic() && !tf->isItalic(),

- fontDescription.orientation());

+ fontDescription.orientation(),

+#if OS(ANDROID)

+ // On Android FontPlatformData from different locales need to be distinguished

+ // to avoid conflict of glyphs from different locale-perferred fallback fonts.

falken 2013/09/25 08:11:51 Same as previous comment.

+ fontDescription.locale());

+#else

+ AtomicString());

+#endif

tf->unref();

return result;

}

« Source/core/platform/graphics/chromium/FontCacheAndroid.cpp ('K') | « Source/core/platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp ('k') | no next file » | no next file with comments »