Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1182)

Unified Diff: Source/core/platform/graphics/FontDescription.h

Issue 23503080: Pass DOM locale to Skia in FontCache::getFontDataForCharacter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@fontcleanup
Patch Set: Pure Android only Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/platform/graphics/FontDescription.h
diff --git a/Source/core/platform/graphics/FontDescription.h b/Source/core/platform/graphics/FontDescription.h
index 7aa15222676c53c5fb101cb7695d1aa15edaa8be..a957192cd37ae01c7843992cdc8c780a342f00f9 100644
--- a/Source/core/platform/graphics/FontDescription.h
+++ b/Source/core/platform/graphics/FontDescription.h
@@ -95,7 +95,6 @@ public:
, m_fontSmoothing(AutoSmoothing)
, m_textRendering(AutoTextRendering)
, m_isSpecifiedFont(false)
- , m_script(USCRIPT_COMMON)
{
}
@@ -124,7 +123,7 @@ public:
unsigned keywordSize() const { return m_keywordSize; }
FontSmoothingMode fontSmoothing() const { return static_cast<FontSmoothingMode>(m_fontSmoothing); }
TextRenderingMode textRenderingMode() const { return static_cast<TextRenderingMode>(m_textRendering); }
- UScriptCode script() const { return static_cast<UScriptCode>(m_script); }
+ AtomicString locale() const { return m_locale; }
FontTraitsMask traitsMask() const;
bool isSpecifiedFont() const { return m_isSpecifiedFont; }
@@ -160,13 +159,15 @@ public:
void setOrientation(FontOrientation orientation) { m_orientation = orientation; }
void setNonCJKGlyphOrientation(NonCJKGlyphOrientation orientation) { m_nonCJKGlyphOrientation = orientation; }
void setWidthVariant(FontWidthVariant widthVariant) { m_widthVariant = widthVariant; }
- void setScript(UScriptCode s) { m_script = s; }
+ void setLocale(const AtomicString& locale) { m_locale = locale; }
void setFeatureSettings(PassRefPtr<FontFeatureSettings> settings) { m_featureSettings = settings; }
private:
FontFamily m_familyList; // The list of font families to be used.
RefPtr<FontFeatureSettings> m_featureSettings;
+ AtomicString m_locale; // Used to help choose an appropriate font for font families based on the DOM locale.
+
float m_specifiedSize; // Specified CSS value. Independent of rendering issues such as integer
// rounding, minimum font sizes, and zooming.
float m_computedSize; // Computed size adjusted for the minimum font size and the zoom factor.
@@ -180,7 +181,7 @@ private:
unsigned m_smallCaps : 1; // FontSmallCaps
unsigned m_isAbsoluteSize : 1; // Whether or not CSS specified an explicit size
// (logical sizes like "medium" don't count).
- unsigned m_weight : 8; // FontWeight
+ unsigned m_weight : 4; // FontWeight
unsigned m_genericFamily : 3; // GenericFamilyType
unsigned m_usePrinterFont : 1;
@@ -197,7 +198,6 @@ private:
unsigned m_fontSmoothing : 2; // FontSmoothingMode
unsigned m_textRendering : 2; // TextRenderingMode
unsigned m_isSpecifiedFont : 1; // True if a web page specifies a non-generic font family as the first font family.
- unsigned m_script : 7; // Used to help choose an appropriate font for generic font families.
};
inline bool FontDescription::operator==(const FontDescription& other) const
@@ -222,7 +222,7 @@ inline bool FontDescription::operator==(const FontDescription& other) const
&& m_orientation == other.m_orientation
&& m_nonCJKGlyphOrientation == other.m_nonCJKGlyphOrientation
&& m_widthVariant == other.m_widthVariant
- && m_script == other.m_script
+ && m_locale == other.m_locale
&& m_featureSettings == other.m_featureSettings;
}

Powered by Google App Engine
This is Rietveld 408576698