Issue 23503064: [Mac] Fix some leaks in tab drawing code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23503064: [Mac] Fix some leaks in tab drawing code. (Closed)

Created:
7 years, 3 months ago by Alexei Svitkine (slow)

Modified:
7 years, 3 months ago

Reviewers:
Nico

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

[Mac] Fix some leaks in tab drawing code. Found by the Mac OS X 'leaks' tool; fixed on a plane. BUG=292905 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223505

Patch Set 1 #

Total comments: 2

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm	View		2 chunks	+2 lines, -2 lines	1 comment	Download
	M	chrome/browser/ui/cocoa/tabs/tab_view.mm	View		1 chunk	+2 lines, -2 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nico

LGTM, thanks. How did I write this :-( Reviewed on an office chair. https://codereview.chromium.org/23503064/diff/1/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm File ...

7 years, 3 months ago (2013-09-16 20:54:21 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/23503064/1

7 years, 3 months ago (2013-09-16 20:56:48 UTC) #3

Message was sent while issue was closed.

Change committed as 223505

Expand Messages | Collapse Messages