Load NPAPI plugin resources through the browser process directly instead of going through the render

Load NPAPI plugin resources through the browser process directly instead of going through the renderer. This is needed because when we have site isolation enabled we won't trust the renderer to fetch urls from arbitrary origins, which is something that NPAPI plugins can do.

In a followup I'll implement range requests.

For now this is behind the --direct-npapi-requests flag.

BUG=286074
R=ananta@chromium.org, jschuh@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222602

[ananta, 2013-09-10 21:29:35]

Looks good. Please add some comments about how FetchURL works starting from the
plugin to the renderer and back.

As implemented this won't work for single process mode. Do we need to support
this?

https://codereview.chromium.org/23503043/diff/141001/content/common/resource_...
File content/common/resource_messages.h (right):

https://codereview.chromium.org/23503043/diff/141001/content/common/resource_...
content/common/resource_messages.h:151: // If kDirectNPAPIRequests isn't
specified, then plugin requests get route
routed

[jam, 2013-09-11 01:24:37]

Thanks, I made this work for single-process mode and added comments in
WebPluginImpl::HandleURLRequestInternal about how this works.

https://codereview.chromium.org/23503043/diff/141001/content/common/resource_...
File content/common/resource_messages.h (right):

https://codereview.chromium.org/23503043/diff/141001/content/common/resource_...
content/common/resource_messages.h:151: // If kDirectNPAPIRequests isn't
specified, then plugin requests get route
On 2013/09/10 21:29:35, ananta wrote:
> routed

Done.

[jam, 2013-09-11 02:29:58]

+jschuh for IPC files
Justin: in plugin_messages.h I added two new IPCs (PluginMsg_FetchURL and
PluginHostMsg_CheckIfRunInsecureContent). the other changes in that file are
just moving the win and mac blocks to the end of their respective section

[jschuh, 2013-09-11 17:34:30]

ipc security lgtm. just moving message plumbing.

[ananta, 2013-09-11 18:18:09]

https://codereview.chromium.org/23503043/diff/199001/content/plugin/webplugin...
File content/plugin/webplugin_proxy.cc (right):

https://codereview.chromium.org/23503043/diff/199001/content/plugin/webplugin...
content/plugin/webplugin_proxy.cc:151: 
Remove

[ananta, 2013-09-11 18:18:15]

lgtm