Site Settings Desktop: Fix crash when altering exception.

chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc

Index: chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc
diff --git a/chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc b/chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc
index 85b4af79192c6926b0fc6c97197d4d7ec731b694..59b33294b6f28ad3c7f4f4df414ea17af3be7f44 100644
--- a/chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc
+++ b/chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc
@@ -15,6 +15,7 @@
 #include "content/public/browser/web_ui_data_source.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "content/public/test/test_web_ui.h"
+#include "extensions/common/extension_builder.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace {
@@ -256,6 +257,58 @@ TEST_F(SiteSettingsHandlerTest, Origins) {
   ValidateNoOrigin(4U);
 }
 
+TEST_F(SiteSettingsHandlerTest, ExceptionHelpers) {
+  ContentSettingsPattern pattern =
+      ContentSettingsPattern::FromString("[*.]google.com");
+  std::unique_ptr<base::DictionaryValue> exception =
+      site_settings::GetExceptionForPage(pattern, pattern,
+          CONTENT_SETTING_BLOCK, "preference", false);
+
+  std::string primary_pattern, secondary_pattern, type;
+  bool incognito;
+  CHECK(exception->GetString(site_settings::kOrigin, &primary_pattern));
+  CHECK(exception->GetString(site_settings::kEmbeddingOrigin,
+                             &secondary_pattern));
+  CHECK(exception->GetString(site_settings::kSetting, &type));
+  CHECK(exception->GetBoolean(site_settings::kIncognito, &incognito));
+
+  base::ListValue args;
+  args.AppendString(primary_pattern);
+  args.AppendString(secondary_pattern);
+  args.AppendString("notifications");  // Picked at random.

[dschuyler, 2016/09/20 18:54:41]

optional: maybe the comment could be // Arbitrary.
Or // Chosen arbitrarily.
Though there's not a lot of people who will care
so much about how the word 'random' is used, so 
it probably doesn't matter.

+  args.AppendString(type);
+  args.AppendBoolean(incognito);
+
+  // We don't need to check the results. This is just to make sure it doesn't
+  // crash on the input.
+  handler()->HandleSetCategoryPermissionForOrigin(&args);
+
+  scoped_refptr<const extensions::Extension> extension;
+  extension = extensions::ExtensionBuilder()
+                  .SetManifest(extensions::DictionaryBuilder()
+                                   .Set("name", "Test extension")
+                                   .Set("version", "1.0.0")
+                                   .Set("manifest_version", 2)
+                                   .Build())
+                  .SetID("ahfgeienlihckogmohjhadlkjgocpleb")
+                  .Build();
+
+  std::unique_ptr<base::ListValue> exceptions(new base::ListValue);
+  site_settings::AddExceptionForHostedApp(
+      "[*.]google.com", *extension.get(), exceptions.get());
+
+  const base::DictionaryValue* dictionary;
+  CHECK(exceptions->GetDictionary(0, &dictionary));
+  CHECK(dictionary->GetString(site_settings::kOrigin, &primary_pattern));
+  CHECK(dictionary->GetString(site_settings::kEmbeddingOrigin,
+                              &secondary_pattern));
+  CHECK(dictionary->GetString(site_settings::kSetting, &type));
+  CHECK(dictionary->GetBoolean(site_settings::kIncognito, &incognito));
+
+  // Again, don't need to check the results.
+  handler()->HandleSetCategoryPermissionForOrigin(&args);
+}
+
 TEST_F(SiteSettingsHandlerTest, Patterns) {
   base::ListValue args;
   std::string pattern("[*.]google.com");