Prune CreateVisiblePositionDeprecated from SurroundingText-related callers

Prune CreateVisiblePositionDeprecated from SurroundingText-related callers

BUG=647219
Committed: https://crrev.com/4b9ac8d39cf15802713a426627cc74dc3b5c658e
Cr-Commit-Position: refs/heads/master@{#419707}

[Xiaocheng, 2016-09-20 06:37:53]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 06:38:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 07:35:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 07:35:24]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Xiaocheng, 2016-09-20 07:36:54]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 07:37:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-09-20 07:37:31]

xiaochengh@chromium.org changed reviewers:
+ tkent@chromium.org

[Xiaocheng, 2016-09-20 07:37:31]

PTAL.

[tkent, 2016-09-20 08:08:21]

https://codereview.chromium.org/2350303003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/testing/Internals.cpp (right):

https://codereview.chromium.org/2350303003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/testing/Internals.cpp:2437: // SurroundingText
must be created in clean layout.
"SurrondingText and VisiblePosition must be..." is better?

Also, we should add DCHECK(!...document().needsLayoutTreeUpdate()) to
SurroundingText::initialize().

[Xiaocheng, 2016-09-20 08:21:41]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 08:21:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-09-20 08:22:18]

Updated. PTAL.

https://codereview.chromium.org/2350303003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/testing/Internals.cpp (right):

https://codereview.chromium.org/2350303003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/testing/Internals.cpp:2437: // SurroundingText
must be created in clean layout.
On 2016/09/20 at 08:08:21, tkent wrote:
> "SurrondingText and VisiblePosition must be..." is better?
> 
> Also, we should add DCHECK(!...document().needsLayoutTreeUpdate()) to
SurroundingText::initialize().

Done.

[tkent, 2016-09-20 08:28:18]

lgtm

[commit-bot: I haz the power, 2016-09-20 09:32:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 09:32:44]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2016-09-20 09:33:15]

The CQ bit was checked by xiaochengh@chromium.org

[commit-bot: I haz the power, 2016-09-20 09:33:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 09:39:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-20 09:41:54]

Description was changed from

==========
Prune CreateVisiblePositionDeprecated from SurroundingText-related callers

BUG=647219
==========

to

==========
Prune CreateVisiblePositionDeprecated from SurroundingText-related callers

BUG=647219

Committed: https://crrev.com/4b9ac8d39cf15802713a426627cc74dc3b5c658e
Cr-Commit-Position: refs/heads/master@{#419707}
==========

[commit-bot: I haz the power, 2016-09-20 09:41:54]

Patchset 2 (id:??) landed as
https://crrev.com/4b9ac8d39cf15802713a426627cc74dc3b5c658e
Cr-Commit-Position: refs/heads/master@{#419707}