Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 23503025: Fix OSR to ignore phis without merge index in loop entry. (Closed)

Created:
7 years, 3 months ago by Michael Starzinger
Modified:
7 years, 3 months ago
Reviewers:
titzer
CC:
v8-dev
Visibility:
Public.

Description

Fix OSR to ignore phis without merge index in loop entry. This fixes a corner case introduced by escape analysis where phis are introduced in OSR loop entry blocks that don't have a merge index and hence cannot contain OSR values. R=titzer@chromium.org TEST=mjsunit/compiler/escape-analysis Committed: http://code.google.com/p/v8/source/detail?r=16484

Patch Set 1 #

Patch Set 2 : Increased test coverage as per offline discussion with Ben Titzer. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -2 lines) Patch
M src/hydrogen-osr.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M test/mjsunit/compiler/escape-analysis.js View 1 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Starzinger
7 years, 3 months ago (2013-09-02 10:40:12 UTC) #1
Michael Starzinger
Addressed offline comments.
7 years, 3 months ago (2013-09-02 12:43:02 UTC) #2
titzer
lgtm
7 years, 3 months ago (2013-09-02 16:47:33 UTC) #3
Michael Starzinger
7 years, 3 months ago (2013-09-02 16:52:17 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r16484 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698