Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 23503008: file_manager: Add DriveAppRegistry::UpdateFromAppList() (Closed)

Created:
7 years, 3 months ago by satorux1
Modified:
7 years, 3 months ago
Reviewers:
kinaba
CC:
chromium-reviews, tfarina, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

file_manager: Add DriveAppRegistry::UpdateFromAppList() This will be useful for writing tests for the file task stuff in chrome/browser/chromeos/extension/file_manager/file_tasks.cc. BUG=269929 TEST=none R=kinaba@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220475

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -2 lines) Patch
M chrome/browser/chromeos/drive/drive_app_registry.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_app_registry.cc View 1 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_app_registry_unittest.cc View 1 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
satorux1
7 years, 3 months ago (2013-08-29 06:49:08 UTC) #1
kinaba
LGTM!
7 years, 3 months ago (2013-08-29 06:51:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/23503008/15001
7 years, 3 months ago (2013-08-30 01:09:45 UTC) #3
satorux1
7 years, 3 months ago (2013-08-30 02:05:09 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r220475 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698