Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2350293002: docs: Removing references to SVN (Closed)

Created:
4 years, 3 months ago by benhenry
Modified:
4 years, 3 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : addressing nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -12 lines) Patch
M README.md View 1 chunk +1 line, -2 lines 0 comments Download
M README.gclient.md View 1 2 chunks +3 lines, -3 lines 0 comments Download
M bootstrap/win/README.md View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
benry
PTAL
4 years, 3 months ago (2016-09-19 20:34:33 UTC) #2
Sergiy Byelozyorov
lgtm https://codereview.chromium.org/2350293002/diff/1/README.gclient.md File README.gclient.md (right): https://codereview.chromium.org/2350293002/diff/1/README.gclient.md#newcode14 README.gclient.md:14: "url" : "https://scmserver/component/trunk/src.git", Why not "gitserver"? https://codereview.chromium.org/2350293002/diff/1/README.gclient.md#newcode17 README.gclient.md:17: ...
4 years, 3 months ago (2016-09-19 21:55:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2350293002/1
4 years, 3 months ago (2016-09-19 22:20:15 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Depot Tools Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/315d5d7a340c5f10)
4 years, 3 months ago (2016-09-19 22:26:26 UTC) #7
benry
Adding more folks from the OWNERS file.
4 years, 3 months ago (2016-09-19 22:39:35 UTC) #9
iannucci
lgtm
4 years, 3 months ago (2016-09-19 22:46:36 UTC) #10
tandrii(chromium)
LGTM % strong nits https://codereview.chromium.org/2350293002/diff/1/README.gclient.md File README.gclient.md (right): https://codereview.chromium.org/2350293002/diff/1/README.gclient.md#newcode14 README.gclient.md:14: "url" : "https://scmserver/component/trunk/src.git", On 2016/09/19 ...
4 years, 3 months ago (2016-09-19 22:46:38 UTC) #11
iannucci
On 2016/09/19 22:46:36, iannucci wrote: > lgtm Though there's still a bunch of svn tools ...
4 years, 3 months ago (2016-09-19 22:47:12 UTC) #12
Sergiy Byelozyorov
On 2016/09/19 22:47:12, iannucci wrote: > On 2016/09/19 22:46:36, iannucci wrote: > > lgtm > ...
4 years, 3 months ago (2016-09-19 23:01:16 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2350293002/20001
4 years, 3 months ago (2016-09-19 23:03:35 UTC) #16
benry
On 2016/09/19 23:01:16, Sergiy Byelozyorov wrote: > On 2016/09/19 22:47:12, iannucci wrote: > > On ...
4 years, 3 months ago (2016-09-19 23:03:42 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 23:06:51 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/186449d3e74a84...

Powered by Google App Engine
This is Rietveld 408576698